kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-20 16:50:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Free successfully translated frame in fax_gateway_framehook

Browse Source 
A frame that is translated via ast_translate is also duplicated via ast_frdup.
This will allocate a new frame on the heap, which needs to be free'd
at the appropriate time.  This issue reporter used valgrind to find that this
occurred in res_fax's fax_gateway_framehook; a quick search through the code
showed that only place this was currently not handling the translatted frame
properly.

(closes issue ASTERISK-19133)
Reported by: Sylvain Rochet
........

Merged revisions 349608 from http://svn.asterisk.org/svn/asterisk/branches/10


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@349609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Matthew Jordan
2012-01-04 21:40:45 +00:00
parent 963d52f63e
commit 12e3f412b5
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
res/res_fax.c
View File

@@ -3086,6 +3086,7 @@ static struct ast_frame *fax_gateway_framehook(struct ast_channel *chan, struct
* write would fail, or even if a failure would be fatal so for * write would fail, or even if a failure would be fatal so for
* now we'll just ignore the return value. */ * now we'll just ignore the return value. */
gateway->s->tech->write(gateway->s, f); gateway->s->tech->write(gateway->s, f);
ast_frfree(f);
f = &ast_null_frame; f = &ast_null_frame;
ao2_ref(details, -1); ao2_ref(details, -1);
return f; return f;