kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-09 11:28:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merged revisions 201458 via svnmerge from

Browse Source 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r201458 | mmichelson | 2009-06-17 15:04:12 -0500 (Wed, 17 Jun 2009) | 15 lines
  
  Merged revisions 201450 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r201450 | mmichelson | 2009-06-17 14:59:31 -0500 (Wed, 17 Jun 2009) | 9 lines
    
    Change the datastore traversal in ast_do_masquerade to use a safe list traversal.
    
    It is possible for datastore fixup functions to remove the datastore from the list
    and free it. In particular, the queue_transfer_fixup in app_queue does this. While
    I don't yet know of this causing any crashes, it certainly could.
    
    Found while discussing a separate issue with Brian Degenhardt.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@201459 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Mark Michelson
2009-06-17 20:05:09 +00:00
parent 48dd606532
commit 3068fa75a2
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
main/channel.c
View File

@@ -4403,10 +4403,14 @@ int ast_do_masquerade(struct ast_channel *original)
/* Move data stores over */ /* Move data stores over */
if (AST_LIST_FIRST(&clone->datastores)) { if (AST_LIST_FIRST(&clone->datastores)) {
struct ast_datastore *ds; struct ast_datastore *ds;
AST_LIST_TRAVERSE(&clone->datastores, ds, entry) { /* We use a safe traversal here because some fixup routines actually
* remove the datastore from the list and free them.
*/
AST_LIST_TRAVERSE_SAFE_BEGIN(&clone->datastores, ds, entry) {
if (ds->info->chan_fixup) if (ds->info->chan_fixup)
ds->info->chan_fixup(ds->data, clone, original); ds->info->chan_fixup(ds->data, clone, original);
} }
AST_LIST_TRAVERSE_SAFE_END;
AST_LIST_APPEND_LIST(&original->datastores, &clone->datastores, entry); AST_LIST_APPEND_LIST(&original->datastores, &clone->datastores, entry);
} }