kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-19 16:20:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang compiler warnings: Fix various warnings for tests

Browse Source 
This patch fixes a variety of clang compiler warnings for unit tests. This
includes autological comparison issues, ignored return values, and
interestingly enough, one embedded function. Fun!

Review: https://reviewboard.asterisk.org/r/4555

ASTERISK-24917
Reported by: dkdegroot
patches:
  rb4555.patch submitted by dkdegroot (License 6600)
........

Merged revisions 434705 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 434706 from http://svn.asterisk.org/svn/asterisk/branches/13


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@434707 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Matthew Jordan
2015-04-11 15:27:08 +00:00
parent 5f181bcccd
commit 356b770632
4 changed files with 29 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/test_strings.c
View File

@@ -390,9 +390,12 @@ AST_TEST_DEFINE(strsep_test)
static int test_semi(char *string1, char *string2, int test_len)
{
char *test2 = NULL;
if (test_len >= 0) {
if (test_len > 0) {
test2 = ast_alloca(test_len);
*test2 = '\0';
} else if (test_len == 0) {
test2 = "";
}
ast_escape_semicolons(string1, test2, test_len);
if (test2 != NULL && strcmp(string2, test2) == 0) {