mirror of
https://github.com/asterisk/asterisk.git
synced 2025-11-07 10:28:32 +00:00
Fix a memory leak when updating a realtime member field.
This was discovered while looking at issue #14353 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@179971 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -1634,20 +1634,26 @@ static struct call_queue *load_realtime_queue(const char *queuename)
|
||||
|
||||
static int update_realtime_member_field(struct member *mem, const char *queue_name, const char *field, const char *value)
|
||||
{
|
||||
struct ast_variable *var;
|
||||
struct ast_variable *var, *origvar;
|
||||
int ret = -1;
|
||||
|
||||
if (!(var = ast_load_realtime("queue_members", "interface", mem->interface, "queue_name", queue_name, NULL)))
|
||||
if (!(var = ast_load_realtime("queue_members", "interface", mem->interface, "queue_name", queue_name, NULL))) {
|
||||
return ret;
|
||||
}
|
||||
|
||||
origvar = var;
|
||||
while (var) {
|
||||
if (!strcmp(var->name, "uniqueid"))
|
||||
if (!strcmp(var->name, "uniqueid")) {
|
||||
break;
|
||||
}
|
||||
var = var->next;
|
||||
}
|
||||
if (var && !ast_strlen_zero(var->value)) {
|
||||
if ((ast_update_realtime("queue_members", "uniqueid", var->value, field, value, NULL)) > -1)
|
||||
if ((ast_update_realtime("queue_members", "uniqueid", var->value, field, value, NULL)) > -1) {
|
||||
ret = 0;
|
||||
}
|
||||
}
|
||||
ast_variables_destroy(origvar);
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user