kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-14 16:33:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

make unit test check for NULL folder, which then defaults to INBOX

Browse Source 
previous test, gave false level of assurance that code was healthy.

(issue #16927)
Reported by: alecdavis
Patches: 
      based on app_voicemail_test.diff.txt uploaded by alecdavis (license 585)

Tested by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249449 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Alec L Davis
2010-02-28 16:36:45 +00:00
parent a6fd85250d
commit 40ee6ed4f0
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/app_voicemail.c
View File

@@ -11682,7 +11682,8 @@ AST_TEST_DEFINE(test_voicemail_msgcount)
/* hasvm-old, hasvm-urgent, hasvm-new, ic-old, ic-urgent, ic-new, ic2-old, ic2-urgent, ic2-new, mc-old, mc-urgent, mc-new */ /* hasvm-old, hasvm-urgent, hasvm-new, ic-old, ic-urgent, ic-new, ic2-old, ic2-urgent, ic2-new, mc-old, mc-urgent, mc-new */
for (j = 0; j < 3; j++) { for (j = 0; j < 3; j++) {
if (ast_app_has_voicemail(testspec, folders[j]) != expected_results[i][0 + j]) { /* folder[2] is INBOX, __has_voicemail will default back to INBOX */
if (ast_app_has_voicemail(testspec, (j==2 ? NULL : folders[j])) != expected_results[i][0 + j]) {
ast_test_status_update(test, "has_voicemail(%s, %s) returned %d and we expected %d\n", ast_test_status_update(test, "has_voicemail(%s, %s) returned %d and we expected %d\n",
testspec, folders[j], ast_app_has_voicemail(testspec, folders[j]), expected_results[i][0 + j]); testspec, folders[j], ast_app_has_voicemail(testspec, folders[j]), expected_results[i][0 + j]);
res = AST_TEST_FAIL; res = AST_TEST_FAIL;