kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

tcptls: when disabling a server port, we should set the accept_fd to -1.

Browse Source 
If we don't set this to -1 if the structure can be potentially re-used
later then it's possible that we'll issue a close() on an unrelated file
descriptor, breaking asterisk in other interesting ways.

I believe this to be an unlikely scenario, but it costs nothing to be
safe.

Signed-off-by: Jaco Kroon <jaco@uls.co.za>
This commit is contained in:
Jaco Kroon
2023-06-02 09:11:22 +02:00
committed by we should set the accept_fd to -1
parent 8e3f9dcc7b
commit 4a637d6d11
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
main/tcptls.c
View File

@@ -837,6 +837,7 @@ void ast_tcptls_server_start(struct ast_tcptls_session_args *desc)
if (desc->accept_fd != -1) {
close(desc->accept_fd);
desc->accept_fd = -1;
}
/* If there's no new server, stop here */