kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-26 22:30:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

main/stun.c: fix crash upon STUN request timeout

Browse Source 
Some ast_stun_request users do not provide a destination address when
sending to a connection-mode socket.

ASTERISK-29691

Change-Id: Idd9114c3380216ba48abfc3c68619e79ad37defc
This commit is contained in:
Sebastien Duthil
2021-10-14 11:15:30 -04:00
committed by Sébastien Duthil
parent 9ff955f4d1
commit 4bc7a5ac53
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
main/stun.c
View File

@@ -239,17 +239,24 @@ static void append_attr_address(struct stun_attr **attr, int attrval, struct soc
static void handle_stun_timeout(int retry, struct sockaddr_in *dst) static void handle_stun_timeout(int retry, struct sockaddr_in *dst)
{ {
char *stun_destination = "";
if (dst) {
ast_asprintf(&stun_destination, "to '%s' ", ast_inet_ntoa(dst->sin_addr));
}
if (retry < STUN_MAX_RETRIES) { if (retry < STUN_MAX_RETRIES) {
ast_log(LOG_NOTICE, ast_log(LOG_NOTICE,
"Attempt %d to send STUN request to '%s' timed out.", "Attempt %d to send STUN request %stimed out.\n",
retry, retry,
ast_inet_ntoa(dst->sin_addr)); stun_destination);
} else { } else {
ast_log(LOG_WARNING, ast_log(LOG_WARNING,
"Attempt %d to send STUN request to '%s' timed out." "Attempt %d to send STUN request %stimed out. "
"Check that the server address is correct and reachable.\n", "Check that the server address is correct and reachable.\n",
retry, retry,
ast_inet_ntoa(dst->sin_addr)); stun_destination);
}
if (dst) {
ast_free(stun_destination);
} }
} }