From 533144b1705574443cddec00ab488601bbb34be3 Mon Sep 17 00:00:00 2001 From: Joshua Colp Date: Thu, 24 May 2007 15:27:23 +0000 Subject: [PATCH] Add the ability to blacklist certain commands from being executed using the Command AMI action. (issue #9240 reported by junky) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65902 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/manager.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/main/manager.c b/main/manager.c index b3933df32c..2b6fbf796e 100644 --- a/main/manager.c +++ b/main/manager.c @@ -129,6 +129,11 @@ static struct permalias { { 0, "none" }, }; +static const char *command_blacklist[] = { + "module load", + "module unload", +}; + struct mansession { /*! Execution thread */ pthread_t t; @@ -1620,9 +1625,16 @@ static int action_command(struct mansession *s, const struct message *m) const char *id = astman_get_header(m, "ActionID"); char *buf, *final_buf; char template[] = "/tmp/ast-ami-XXXXXX"; /* template for temporary file */ - int fd = mkstemp(template); + int fd = mkstemp(template), i = 0; off_t l; + for (i = 0; i < sizeof(command_blacklist) / sizeof(command_blacklist[0]); i++) { + if (!strncmp(cmd, command_blacklist[i], strlen(command_blacklist[i]))) { + astman_send_error(s, m, "Command blacklisted"); + return 0; + } + } + astman_append(s, "Response: Follows\r\nPrivilege: Command\r\n"); if (!ast_strlen_zero(id)) astman_append(s, "ActionID: %s\r\n", id);