kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-29 18:19:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

app_confbridge: Fix NULL check in action_kick_last.

Browse Source 
The check for last_user == NULL needs to happen before we dereference
the variable, previously it was possible for us to check flags of a NULL
last_user.

Change-Id: I274f737aa8af9d2d53e4a78cdd7ad57561003945
This commit is contained in:
Corey Farrell
2018-01-08 19:47:38 -05:00
parent 8e18209cad
commit 5380fb9978
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
apps/app_confbridge.c
View File

@@ -2689,17 +2689,23 @@ static int action_kick_last(struct confbridge_conference *conference,
} }
ao2_lock(conference); ao2_lock(conference);
if (((last_user = AST_LIST_LAST(&conference->active_list)) == user) last_user = AST_LIST_LAST(&conference->active_list);
|| (ast_test_flag(&last_user->u_profile, USER_OPT_ADMIN))) { if (!last_user) {
ao2_unlock(conference);
return 0;
}
if (last_user == user || ast_test_flag(&last_user->u_profile, USER_OPT_ADMIN)) {
ao2_unlock(conference); ao2_unlock(conference);
play_file(bridge_channel, NULL, play_file(bridge_channel, NULL,
conf_get_sound(CONF_SOUND_ERROR_MENU, conference->b_profile.sounds)); conf_get_sound(CONF_SOUND_ERROR_MENU, conference->b_profile.sounds));
} else if (last_user && !last_user->kicked) { } else if (!last_user->kicked) {
last_user->kicked = 1; last_user->kicked = 1;
pbx_builtin_setvar_helper(last_user->chan, "CONFBRIDGE_RESULT", "KICKED"); pbx_builtin_setvar_helper(last_user->chan, "CONFBRIDGE_RESULT", "KICKED");
ast_bridge_remove(conference->bridge, last_user->chan); ast_bridge_remove(conference->bridge, last_user->chan);
ao2_unlock(conference); ao2_unlock(conference);
} }
return 0; return 0;
} }