kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

ari: Fix deadlock problem with functions that use autoservice.

Browse Source 
The code for getting channel variables from ARI assumed that you needed
to lock the channel in order to properly execute functions and read
channel variables. Apparently, this is not the case, since any dialplan
function that puts the channel into autoservice deadlocks when
attempting to remove the channel from autoservice.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@403342 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
David M. Lee
2013-12-03 20:17:48 +00:00
parent 3dfd810c6c
commit 55798c532a
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
res/stasis/control.c
View File

@@ -426,7 +426,13 @@ int stasis_app_control_unmute(struct stasis_app_control *control, unsigned int d
char *stasis_app_control_get_channel_var(struct stasis_app_control *control, const char *variable)
{
RAII_VAR(struct ast_str *, tmp, ast_str_create(32), ast_free);
SCOPED_CHANNELLOCK(lockvar, control->channel);
/* You may be tempted to lock the channel you're about to read from. You
* would be wrong. Some dialplan functions put the channel into
* autoservice, which deadlocks if the channel is already locked.
* ast_str_retrieve_variable() does its own locking, and the dialplan
* functions need to as well. We should be fine without the lock.
*/
if (!tmp) {
return NULL;