kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unsafe uses of ast_context pointers.

Browse Source 
Although ast_context_find, ast_context_find_or_create and
ast_context_destroy perform locking of the contexts table,
any context pointer can become invalid at any time that the
contexts table is unlocked. This change adds locking around
all complete operations involving these functions.

Places where ast_context_find was followed by ast_context_destroy
have been replaced with calls ast_context_destroy_by_name.

ASTERISK-25094 #close
Reported by: Corey Farrell

Change-Id: I1866b6787730c9c4f3f836b6133ffe9c820734fa
This commit is contained in:
Corey Farrell
2015-06-08 11:09:22 -04:00
parent 720251f2b8
commit 55c8daf88b
9 changed files with 69 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
include/asterisk/pbx.h
View File

@@ -300,7 +300,21 @@ struct ast_context *ast_context_find_or_create(struct ast_context **extcontexts,
void ast_merge_contexts_and_delete(struct ast_context **extcontexts, struct ast_hashtab *exttable, const char *registrar);
/*!
* \brief Destroy a context (matches the specified context (or ANY context if NULL)
* \brief Destroy a context by name
*
* \param context Name of the context to destroy
* \param registrar who registered it
*
* You can optionally leave out the registrar parameter. It will find it
* based on the context name.
*
* \retval -1 context not found
* \retval 0 Success
*/
int ast_context_destroy_by_name(const char *context, const char *registrar);
/*!
* \brief Destroy a context (matches the specified context or ANY context if NULL)
*
* \param con context to destroy
* \param registrar who registered it