kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-31 18:55:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

If the sip private structure is null, sip_setoption() will defref the null pointer and crash.

Browse Source 
Ideally, sip_setoption shouldn't be called if there is a lack of a sip private structure.  But this will fix a crash.

(closes issue ASTERISK-17909)
Reported by: Mark Murawski
Tested by: Mark Murawski



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@328608 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Mark Murawki
2011-07-18 12:35:57 +00:00
parent e739fd42fc
commit 58a56845a6
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
channels/chan_sip.c
View File

@@ -4231,6 +4231,11 @@ static int sip_setoption(struct ast_channel *chan, int option, void *data, int d
int res = -1; int res = -1;
struct sip_pvt *p = chan->tech_pvt; struct sip_pvt *p = chan->tech_pvt;
if (!p) {
ast_log(LOG_ERROR, "Attempt to Ref a null pointer. sip private structure is gone!\n");
return -1;
}
sip_pvt_lock(p); sip_pvt_lock(p);
switch (option) { switch (option) {