mirror of
				https://github.com/asterisk/asterisk.git
				synced 2025-10-31 10:47:18 +00:00 
			
		
		
		
	If the sip private structure is null, sip_setoption() will defref the null pointer and crash.
Ideally, sip_setoption shouldn't be called if there is a lack of a sip private structure. But this will fix a crash. (closes issue ASTERISK-17909) Reported by: Mark Murawski Tested by: Mark Murawski git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@328608 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
		| @@ -4231,6 +4231,11 @@ static int sip_setoption(struct ast_channel *chan, int option, void *data, int d | |||||||
| 	int res = -1; | 	int res = -1; | ||||||
| 	struct sip_pvt *p = chan->tech_pvt; | 	struct sip_pvt *p = chan->tech_pvt; | ||||||
| 
 | 
 | ||||||
|  |         if (!p) { | ||||||
|  |         	ast_log(LOG_ERROR, "Attempt to Ref a null pointer.  sip private structure is gone!\n"); | ||||||
|  |         	return -1; | ||||||
|  |         } | ||||||
|  | 
 | ||||||
| 	sip_pvt_lock(p); | 	sip_pvt_lock(p); | ||||||
| 
 | 
 | ||||||
| 	switch (option) { | 	switch (option) { | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user