kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-17 07:18:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_rtp_asterisk: Add support for sending NACK requests.

Browse Source 
Support has been added for receiving a NACK request and handling it.
Now, Asterisk can detect when a NACK request should be sent and knows
how to construct one based on the packets we've received from the remote
end. A buffer has been added that will store out of order packets until
we receive the packet we are expecting. Then, these packets are handled
like normal and frames are queued to the core like normal. Asterisk
knows which packets to request in the NACK request using a vector
which stores the sequence numbers of the packets we are currently missing.

If a missing packet is received, cycle through the buffer until we reach
another packet we have not received yet. If the buffer reaches a certain
size, send a NACK request. If the buffer reaches its max size, queue all
frames to the core and wipe the buffer and vector.

According to RFC3711, the NACK request must be sent out in a compound
packet. All compound packets must start with a sender or receiver
report, so some work was done to refactor the current sender / receiver
code to allow it to be used without having to also include sdes
information and automatically send the report.

Also added additional functionality to ast_data_buffer, along with some
testing.

For more information, refer to the wiki page:
https://wiki.asterisk.org/wiki/display/AST/WebRTC+User+Experience+Improvements

ASTERISK-27810 #close

Change-Id: Idab644b08a1593659c92cda64132ccc203fe991d
This commit is contained in:
Ben Ford
2018-05-10 13:11:06 -05:00
committed by Benjamin Keith Ford
parent 5f01f73f51
commit 5bacde37a2
4 changed files with 902 additions and 352 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
include/asterisk/data_buffer.h
View File

@@ -110,6 +110,35 @@ int ast_data_buffer_put(struct ast_data_buffer *buffer, size_t pos, void *payloa
*/
void *ast_data_buffer_get(const struct ast_data_buffer *buffer, size_t pos);
/*!
* \brief Remove a data payload from the data buffer
*
* \param buffer The data buffer
* \param pos The position of the data payload
*
* \retval non-NULL success
* \retval NULL failure
*
* \note This DOES remove the data payload from the data buffer. It does not free it, though.
*
* \since 15.5.0
*/
void *ast_data_buffer_remove(struct ast_data_buffer *buffer, size_t pos);
/*!
* \brief Remove the first payload from the data buffer
*
* \param buffer The data buffer
*
* \retval non-NULL success
* \retval NULL failure
*
* \note This DOES remove the data payload from the data buffer.
*
* \since 15.5.0
*/
void *ast_data_buffer_remove_head(struct ast_data_buffer *buffer);
/*!
* \brief Free a data buffer (and all held data payloads)
*