kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-25 15:08:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_pjsip_sdp_rtp: Fix return code from apply_negotiated_sdp_stream

Browse Source 
apply_negotiated_sdp_stream was returning a "1" when no joint
capabilities were found on an outgoing call instead of a "-1".
This indicated to res_pjsip_session that the handler DID handle
the sdp when in fact it didn't.  Without the appropriate setup,
a subsequent media frame coming in would have an invalid stream_num
and cause a seg fault when the stream was attempted to be retrieved.

apply_negotiated_sdp_stream now returns the correct "-1" and any
media is now discarded before it reaches the core stream processing.

ASTERISK-28260
Reported by: Sotiris Ganouris

Change-Id: Ia095cb16b4862f2f6ad6d2d2a77453fa2542371f
This commit is contained in:
George Joseph
2019-01-30 12:25:55 -07:00
parent 1d7df1d3f1
commit 61585af9bd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
res/res_pjsip_sdp_rtp.c
View File

@@ -1946,7 +1946,7 @@ static int apply_negotiated_sdp_stream(struct ast_sip_session *session,
} }
if (set_caps(session, session_media, session_media_transport, remote_stream, 0, asterisk_stream)) { if (set_caps(session, session_media, session_media_transport, remote_stream, 0, asterisk_stream)) {
return 1; return -1;
} }
/* Set the channel uniqueid on the RTP instance now that it is becoming active */ /* Set the channel uniqueid on the RTP instance now that it is becoming active */