kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a crash in the ChanSpy application. The issue here is that if you call

Browse Source 
ChanSpy and specify a spy group, and sit in the application long enough looping
through the channel list, you will eventually run out of stack space and the
application with exit with a seg fault.  The backtrace was always inside of
a harmless snprintf() call, so it was tricky to track down.  However, it turned
out that the call to snprintf() was just the biggest stack consumer in this
code path, so it would always be the first one to hit the boundary.

(closes issue #13338)
Reported by: ruddy


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@139213 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Russell Bryant
2008-08-20 22:14:35 +00:00
parent 54388197d2
commit 6177d367e2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/app_chanspy.c
View File

@@ -555,7 +555,7 @@ static int common_exec(struct ast_channel *chan, const struct ast_flags *flags,
int igrp = !mygroup; int igrp = !mygroup;
char *groups[25]; char *groups[25];
int num_groups = 0; int num_groups = 0;
char *dup_group; char dup_group[512];
int x; int x;
char *s; char *s;
@@ -587,7 +587,7 @@ static int common_exec(struct ast_channel *chan, const struct ast_flags *flags,
if (mygroup) { if (mygroup) {
if ((group = pbx_builtin_getvar_helper(peer, "SPYGROUP"))) { if ((group = pbx_builtin_getvar_helper(peer, "SPYGROUP"))) {
dup_group = ast_strdupa(group); ast_copy_string(dup_group, group, sizeof(dup_group));
num_groups = ast_app_separate_args(dup_group, ':', groups, num_groups = ast_app_separate_args(dup_group, ':', groups,
sizeof(groups) / sizeof(groups[0])); sizeof(groups) / sizeof(groups[0]));
} }