mirror of
https://github.com/asterisk/asterisk.git
synced 2025-11-20 00:30:20 +00:00
This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88166 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -1025,7 +1025,6 @@ static int sendmail(struct minivm_template *template, struct minivm_account *vmu
|
||||
|
||||
ast_debug(4, "-_-_- Fromaddress template: %s\n", fromaddress);
|
||||
if ((passdata = alloca(vmlen))) {
|
||||
memset(passdata, 0, vmlen);
|
||||
pbx_substitute_variables_helper(ast, fromaddress, passdata, vmlen);
|
||||
len_passdata = strlen(passdata) * 2 + 3;
|
||||
passdata2 = alloca(len_passdata);
|
||||
@@ -1050,7 +1049,6 @@ static int sendmail(struct minivm_template *template, struct minivm_account *vmu
|
||||
char *passdata;
|
||||
int vmlen = strlen(template->subject) * 3 + 200;
|
||||
if ((passdata = alloca(vmlen))) {
|
||||
memset(passdata, 0, vmlen);
|
||||
pbx_substitute_variables_helper(ast, template->subject, passdata, vmlen);
|
||||
fprintf(p, "Subject: %s\n", passdata);
|
||||
} else {
|
||||
@@ -1082,7 +1080,6 @@ static int sendmail(struct minivm_template *template, struct minivm_account *vmu
|
||||
char *passdata;
|
||||
int vmlen = strlen(template->body)*3 + 200;
|
||||
if ((passdata = alloca(vmlen))) {
|
||||
memset(passdata, 0, vmlen);
|
||||
pbx_substitute_variables_helper(ast, template->body, passdata, vmlen);
|
||||
ast_debug(3, "Message now: %s\n-----\n", passdata);
|
||||
fprintf(p, "%s\n", passdata);
|
||||
|
||||
Reference in New Issue
Block a user