From 675b2b8103da5551fcf19398cb0793b8602d4452 Mon Sep 17 00:00:00 2001 From: Matthew Jordan Date: Sun, 8 Feb 2015 17:24:01 +0000 Subject: [PATCH] res/res_pjsip_sdp_rtp: Fix leak of local ICE candidates when applying to SDP When an SDP is created for an outgoing request/response, the ICE candidates obtained from the RTP instance are currently leaked. This causes the ao2 container that holds the candidates to never properly be reclaimed when the RTP instance is destroyed. This patch properly decrements the ICE candidates' container if it is successfully obtained. ASTERISK-24769 #close Reported by: Matt Jordan git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@431600 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- res/res_pjsip_sdp_rtp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/res/res_pjsip_sdp_rtp.c b/res/res_pjsip_sdp_rtp.c index fb194c54e9..6471341b33 100644 --- a/res/res_pjsip_sdp_rtp.c +++ b/res/res_pjsip_sdp_rtp.c @@ -396,6 +396,7 @@ static void add_ice_to_stream(struct ast_sip_session *session, struct ast_sip_se } ao2_iterator_destroy(&it_candidates); + ao2_ref(candidates, -1); } /*! \brief Function which processes ICE attributes in an audio stream */