kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace most uses of ast_register_atexit with ast_register_cleanup.

Browse Source 
Since 'core stop now' and 'core restart now' do not stop modules,
it is unsafe for most of the core to run cleanups.  Originally all
cleanups used ast_register_atexit, and were only changed when it
was shown to be unsafe.  ast_register_atexit is now used only when
absolutely required to prevent corruption and close child processes.

Exceptions that need to use ast_register_atexit:
* CDR: Flush records.
* res_musiconhold: Kill external applications.
* AstDB: Close the DB.
* canary_exit: Kill canary process.

ASTERISK-24142 #close
Reported by: David Brillert

ASTERISK-24683 #close
Reported by: Peter Katzmann

ASTERISK-24805 #close
Reported by: Badalian Vyacheslav

ASTERISK-24881 #close
Reported by: Corey Farrell

Review: https://reviewboard.asterisk.org/r/4500/
Review: https://reviewboard.asterisk.org/r/4501/
........

Merged revisions 433495 from http://svn.asterisk.org/svn/asterisk/branches/11


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@433497 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Corey Farrell
2015-03-26 22:19:21 +00:00
parent d0df545a44
commit 6adf26f14d
45 changed files with 65 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
main/core_local.c
View File

@@ -1009,14 +1009,6 @@ static void local_shutdown(void)
ast_manager_unregister("LocalOptimizeAway");
ast_channel_unregister(&local_tech);
it = ao2_iterator_init(locals, 0);
while ((p = ao2_iterator_next(&it))) {
if (p->base.owner) {
ast_softhangup(p->base.owner, AST_SOFTHANGUP_APPUNLOAD);
}
ao2_ref(p, -1);
}
ao2_iterator_destroy(&it);
ao2_ref(locals, -1);
locals = NULL;
@@ -1066,6 +1058,6 @@ int ast_local_init(void)
ast_cli_register_multiple(cli_local, ARRAY_LEN(cli_local));
ast_manager_register_xml_core("LocalOptimizeAway", EVENT_FLAG_SYSTEM|EVENT_FLAG_CALL, manager_optimize_away);
ast_register_atexit(local_shutdown);
ast_register_cleanup(local_shutdown);
return 0;
}