mirror of
https://github.com/asterisk/asterisk.git
synced 2025-09-30 02:26:23 +00:00
fix buggy (and overly complex) loop used during reload of app_queue for static member list updating
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -3306,7 +3306,7 @@ static void reload_queues(void)
|
|||||||
struct ast_config *cfg;
|
struct ast_config *cfg;
|
||||||
char *cat, *tmp;
|
char *cat, *tmp;
|
||||||
struct ast_variable *var;
|
struct ast_variable *var;
|
||||||
struct member *prev, *cur, *newm;
|
struct member *prev, *cur, *newm, *next;
|
||||||
int new;
|
int new;
|
||||||
char *general_val = NULL;
|
char *general_val = NULL;
|
||||||
char interface[80];
|
char interface[80];
|
||||||
@@ -3405,23 +3405,21 @@ static void reload_queues(void)
|
|||||||
}
|
}
|
||||||
|
|
||||||
/* Free remaining members marked as delme */
|
/* Free remaining members marked as delme */
|
||||||
for (prev = NULL, newm = NULL, cur = q->members; cur; prev = cur, cur = cur->next) {
|
for (prev = NULL, cur = q->members, next = cur ? cur->next : NULL;
|
||||||
if (newm) {
|
cur;
|
||||||
free(newm);
|
cur = next, next = cur ? cur->next : NULL) {
|
||||||
newm = NULL;
|
if (!cur->delme)
|
||||||
|
continue;
|
||||||
|
|
||||||
|
if (prev)
|
||||||
|
prev->next = next;
|
||||||
|
else
|
||||||
|
q->members = next;
|
||||||
|
|
||||||
|
remove_from_interfaces(cur->interface);
|
||||||
|
free(cur);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (cur->delme) {
|
|
||||||
if (prev) {
|
|
||||||
prev->next = cur->next;
|
|
||||||
newm = cur;
|
|
||||||
} else {
|
|
||||||
q->members = cur->next;
|
|
||||||
newm = cur;
|
|
||||||
}
|
|
||||||
remove_from_interfaces(cur->interface);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
if (!new)
|
if (!new)
|
||||||
ast_mutex_unlock(&q->lock);
|
ast_mutex_unlock(&q->lock);
|
||||||
if (new) {
|
if (new) {
|
||||||
|
Reference in New Issue
Block a user