mirror of
https://github.com/asterisk/asterisk.git
synced 2025-11-19 00:00:09 +00:00
Fix printf problems with high ascii characters after r413586 (1.8).
In r413586 (1.8) various casts were added to silence gcc 4.10 warnings.
Those fixes included things like:
-out += sprintf(out, "%%%02X", (unsigned char) *ptr);
+out += sprintf(out, "%%%02X", (unsigned) *ptr);
That works for low ascii characters, but for the high range that yields
e.g. FFFFFFC3 when C3 is expected.
This changeset:
- fixes those casts to use the 'hh' unsigned char modifier instead
- consistently uses %02x instead of %2.2x (or other non-standard usage)
- adds a few 'h' modifiers in various places
- fixes a 'replcaes' typo
- dev/urandon typo (in 13+ patch)
Review: https://reviewboard.asterisk.org/r/4263/
ASTERISK-24619 #close
Reported by: Stefan27 (on IRC)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@429673 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -304,7 +304,7 @@ static int printdigest(const unsigned char *d)
|
||||
char buf[256]; /* large enough so we don't have to worry */
|
||||
|
||||
for (pos = 0, x = 0; x < 16; x++)
|
||||
pos += sprintf(buf + pos, " %02x", (unsigned)*d++);
|
||||
pos += sprintf(buf + pos, " %02hhx", *d++);
|
||||
|
||||
ast_debug(1, "Unexpected signature:%s\n", buf);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user