kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

dns_core: Allow zero-length DNS responses.

Browse Source 
A testsuite test recently failed due to a crash that occurred in the DNS
core. The problem was that the test could not resolve an address, did
not set a result on the DNS query, and then indicated the query was
completed. The DNS core does not handle the case of a query with no
result gracefully, and so there is a crash.

This changeset makes the DNS system resolver set a result with a
zero-length answer in the case that a DNS resolution failure occurs
early. The DNS core now also will accept such a response without
treating it as invalid input. A unit test was updated to no longer treat
setting a zero-length response as off-nominal.

Change-Id: Ie56641e22debdaa61459e1c9a042e23b78affbf6
This commit is contained in:
Mark Michelson
2015-07-29 12:58:23 -05:00
parent 687597ca8c
commit 86034227ca
4 changed files with 10 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/test_dns.c
View File

@@ -365,9 +365,7 @@ AST_TEST_DEFINE(resolver_set_result_off_nominal)
info->description =
"This test performs the following:\n"
"\t* Attempt to add a DNS result that is both bogus and secure\n"
"\t* Attempt to add a DNS result that has no canonical name\n"
"\t* Attempt to add a DNS result that has no answer\n"
"\t* Attempt to add a DNS result with a zero answer size";
"\t* Attempt to add a DNS result that has no canonical name";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -391,22 +389,6 @@ AST_TEST_DEFINE(resolver_set_result_off_nominal)
return AST_TEST_FAIL;
}
if (!ast_dns_resolver_set_result(&some_query, 0, 0, ns_r_noerror, NULL,
NULL, DNS_ANSWER_SIZE)) {
ast_test_status_update(test, "Successfully added result with no answer\n");
result = ast_dns_query_get_result(&some_query);
ast_dns_result_free(result);
return AST_TEST_FAIL;
}
if (!ast_dns_resolver_set_result(&some_query, 0, 0, ns_r_noerror, NULL,
DNS_ANSWER, 0)) {
ast_test_status_update(test, "Successfully added result with answer size of zero\n");
result = ast_dns_query_get_result(&some_query);
ast_dns_result_free(result);
return AST_TEST_FAIL;
}
return AST_TEST_PASS;
}