kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-20 16:50:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

mention issues with the protection of the list used in indications.c

Browse Source 
(part of work done to figure out what is used and what is not in lock.h)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@16124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Luigi Rizzo
2006-03-29 16:00:51 +00:00
parent acacae4e68
commit 8f5bf61ef8
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
indications.c
View File

@@ -336,6 +336,16 @@ static struct tone_zone *current_tonezone;
/* Protect the tone_zones list (highly unlikely that two things would change /* Protect the tone_zones list (highly unlikely that two things would change
* it at the same time, but still! */ * it at the same time, but still! */
AST_MUTEX_DEFINE_EXPORTED(tzlock); AST_MUTEX_DEFINE_EXPORTED(tzlock);
/* XXX note - this is the only instance of AST_MUTEX_DEFINE_EXPORTED()
* in the entire asterisk code base, and should be replaced by a static one.
* The mutex is declared exported because it is accessed
* by other files, namely res/snmp/agent.c and res/res_indications.c.
* However there are also unprotected accesses to the list, because
* some of the functions below export pointers to the elements, so
* the entire mechanism is useless.
* This needs to be fixed by providing functions to navigate in the
* list, and refcounts to prevent entries from being destroyed.
*/
/* Set global indication country */ /* Set global indication country */
int ast_set_indication_country(const char *country) int ast_set_indication_country(const char *country)