mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-22 20:56:39 +00:00
Clean up and ensure proper usage of alloca()
This replaces all calls to alloca() with ast_alloca() which calls gcc's __builtin_alloca() to avoid BSD semantics and removes all NULL checks on memory allocated via ast_alloca() and ast_strdupa(). (closes issue ASTERISK-20125) Review: https://reviewboard.asterisk.org/r/2032/ Patch-by: Walter Doekes (wdoekes) ........ Merged revisions 370642 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 370643 from http://svn.asterisk.org/svn/asterisk/branches/10 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@370655 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -1553,14 +1553,16 @@ static struct ast_channel *jingle_request(const char *type, struct ast_format_ca
|
||||
|
||||
if (data) {
|
||||
s = ast_strdupa(data);
|
||||
if (s) {
|
||||
sender = strsep(&s, "/");
|
||||
if (sender && (sender[0] != '\0'))
|
||||
to = strsep(&s, "/");
|
||||
if (!to) {
|
||||
ast_log(LOG_ERROR, "Bad arguments in Jingle Dialstring: %s\n", data);
|
||||
return NULL;
|
||||
}
|
||||
sender = strsep(&s, "/");
|
||||
if (sender && (sender[0] != '\0'))
|
||||
to = strsep(&s, "/");
|
||||
if (!to) {
|
||||
ast_log(LOG_ERROR, "Bad arguments in Jingle Dialstring: %s\n", data);
|
||||
return NULL;
|
||||
}
|
||||
if (!to) {
|
||||
ast_log(LOG_ERROR, "Bad arguments in Jingle Dialstring: %s\n", (char*) data);
|
||||
return NULL;
|
||||
}
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user