mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-12 15:45:18 +00:00
Clean up and ensure proper usage of alloca()
This replaces all calls to alloca() with ast_alloca() which calls gcc's __builtin_alloca() to avoid BSD semantics and removes all NULL checks on memory allocated via ast_alloca() and ast_strdupa(). (closes issue ASTERISK-20125) Review: https://reviewboard.asterisk.org/r/2032/ Patch-by: Walter Doekes (wdoekes) ........ Merged revisions 370642 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 370643 from http://svn.asterisk.org/svn/asterisk/branches/10 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@370655 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -684,7 +684,7 @@ static int func_mchan_read(struct ast_channel *chan, const char *function,
|
||||
char *data, struct ast_str **buf, ssize_t len)
|
||||
{
|
||||
struct ast_channel *mchan = ast_channel_get_by_name(ast_channel_linkedid(chan));
|
||||
char *template = alloca(4 + strlen(data));
|
||||
char *template = ast_alloca(4 + strlen(data));
|
||||
sprintf(template, "${%s}", data); /* SAFE */
|
||||
ast_str_substitute_variables(buf, len, mchan ? mchan : chan, template);
|
||||
if (mchan) {
|
||||
|
Reference in New Issue
Block a user