mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-13 16:21:01 +00:00
Have the manager interface send back an "Already logged in" message instead of "Invalid/Unknown Command" when the client authenticates for a second time. (issue #8509 reported by pari)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52373 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -2021,22 +2021,29 @@ static int process_message(struct mansession *s, const struct message *m)
|
|||||||
} else
|
} else
|
||||||
astman_send_error(s, m, "Authentication Required");
|
astman_send_error(s, m, "Authentication Required");
|
||||||
} else {
|
} else {
|
||||||
ast_mutex_lock(&actionlock);
|
if (!strcasecmp(action, "Login")) {
|
||||||
for (tmp = first_action; tmp; tmp = tmp->next) {
|
|
||||||
if (strcasecmp(action, tmp->action))
|
|
||||||
continue;
|
|
||||||
ast_mutex_lock(&s->__lock);
|
ast_mutex_lock(&s->__lock);
|
||||||
if ((s->writeperm & tmp->authority) == tmp->authority) {
|
astman_send_ack(s, m, "Already logged in");
|
||||||
if (tmp->func(s, m))
|
|
||||||
ret = -1;
|
|
||||||
} else
|
|
||||||
astman_send_error(s, m, "Permission denied");
|
|
||||||
ast_mutex_unlock(&s->__lock);
|
ast_mutex_unlock(&s->__lock);
|
||||||
break;
|
} else {
|
||||||
|
ast_mutex_lock(&actionlock);
|
||||||
|
for (tmp = first_action; tmp; tmp = tmp->next) {
|
||||||
|
if (strcasecmp(action, tmp->action))
|
||||||
|
continue;
|
||||||
|
ast_mutex_lock(&s->__lock);
|
||||||
|
if ((s->writeperm & tmp->authority) == tmp->authority) {
|
||||||
|
if (tmp->func(s, m))
|
||||||
|
ret = -1;
|
||||||
|
} else
|
||||||
|
astman_send_error(s, m, "Permission denied");
|
||||||
|
ast_mutex_unlock(&s->__lock);
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
|
ast_mutex_unlock(&actionlock);
|
||||||
|
if (!tmp)
|
||||||
|
astman_send_error(s, m, "Invalid/unknown command");
|
||||||
}
|
}
|
||||||
ast_mutex_unlock(&actionlock);
|
|
||||||
if (!tmp)
|
|
||||||
astman_send_error(s, m, "Invalid/unknown command");
|
|
||||||
}
|
}
|
||||||
if (ret)
|
if (ret)
|
||||||
return ret;
|
return ret;
|
||||||
|
Reference in New Issue
Block a user