diff --git a/callerid.c b/callerid.c index c1137473fc..3f71189b21 100644 --- a/callerid.c +++ b/callerid.c @@ -219,7 +219,7 @@ void callerid_get_dtmf(char *cidstring, char *number, int *flags) "parsing might be unreliable\n"); for (i = 0; i < strlen(cidstring); i++) { if (isdigit(cidstring[i])) - number[i] = cidstring[i]; + number[i] = cidstring[i]; else break; } @@ -254,21 +254,24 @@ int ast_gen_cas(unsigned char *outbuf, int sendsas, int len, int codec) static unsigned short calc_crc(unsigned short crc, unsigned char data) { - unsigned int i, j, org, dst; - org = data; - dst = 0; - for (i=0; i>= 1; - if (org & 0x100) { - dst |= 0x80; - } - } - data = (unsigned char)dst; + unsigned int i, j, org, dst; + org = data; + dst = 0; + + for (i=0; i < CHAR_BIT; i++) { + org <<= 1; + dst >>= 1; + if (org & 0x100) { + dst |= 0x80; + } + } + data = (unsigned char)dst; crc ^= (unsigned int)data << (16 - CHAR_BIT); for ( j=0; joldlen/2] = AST_XLAW(ubuf[x]); while (mylen >= 160) { - b = b2 = 0 ; + b = b2 = 0 ; olen = mylen; res = fsk_serie(&cid->fskd, buf, &mylen, &b); @@ -407,103 +410,108 @@ int callerid_feed_jp(struct callerid_state *cid, unsigned char *ubuf, int len, i /* extract caller id data */ for (x=0; xpos; ) { switch (cid->rawdata[x++]) { - case 0x02: /* caller id number */ - cid->number[0] = '\0'; - cid->name[0] = '\0'; - cid->flags = 0; - res = cid->rawdata[x++]; - ast_copy_string(cid->number, &cid->rawdata[x], res+1 ); - x += res; - break; - case 0x21: /* additional information */ - /* length */ - x++; - /* number type */ - switch (cid->rawdata[x]) { - case 0x00: /* unknown */ - case 0x01: /* international number */ - case 0x02: /* domestic number */ - case 0x03: /* network */ - case 0x04: /* local call */ - case 0x06: /* short dial number */ - case 0x07: /* reserved */ - default: /* reserved */ - ast_log(LOG_NOTICE, "cid info:#1=%X\n", cid->rawdata[x]); - break ; - } - x++; - /* numbering plan octed 4 */ - x++; - /* numbering plan octed 5 */ - switch (cid->rawdata[x]) { - case 0x00: /* unknown */ - case 0x01: /* recommendation E.164 ISDN */ - case 0x03: /* recommendation X.121 */ - case 0x04: /* telex dial plan */ - case 0x08: /* domestic dial plan */ - case 0x09: /* private dial plan */ - case 0x05: /* reserved */ - default: /* reserved */ - ast_log(LOG_NOTICE, "cid info:#2=%X\n", cid->rawdata[x]); - break ; - } - x++; + case 0x02: /* caller id number */ + cid->number[0] = '\0'; + cid->name[0] = '\0'; + cid->flags = 0; + res = cid->rawdata[x++]; + ast_copy_string(cid->number, &cid->rawdata[x], res+1 ); + x += res; + break; + case 0x21: /* additional information */ + /* length */ + x++; + /* number type */ + switch (cid->rawdata[x]) { + case 0x00: /* unknown */ + case 0x01: /* international number */ + case 0x02: /* domestic number */ + case 0x03: /* network */ + case 0x04: /* local call */ + case 0x06: /* short dial number */ + case 0x07: /* reserved */ + default: /* reserved */ + if (option_debug > 1) + ast_log(LOG_DEBUG, "cid info:#1=%X\n", cid->rawdata[x]); break ; - case 0x04: /* no callerid reason */ - /* length */ - x++; - /* no callerid reason code */ - switch (cid->rawdata[x]) { - case 'P': /* caller id denied by user */ - case 'O': /* service not available */ - case 'C': /* pay phone */ - case 'S': /* service congested */ - cid->flags |= CID_UNKNOWN_NUMBER; - ast_log(LOG_NOTICE, "no cid reason:%c\n",cid->rawdata[x]); - break ; - } - x++; + } + x++; + /* numbering plan octed 4 */ + x++; + /* numbering plan octed 5 */ + switch (cid->rawdata[x]) { + case 0x00: /* unknown */ + case 0x01: /* recommendation E.164 ISDN */ + case 0x03: /* recommendation X.121 */ + case 0x04: /* telex dial plan */ + case 0x08: /* domestic dial plan */ + case 0x09: /* private dial plan */ + case 0x05: /* reserved */ + default: /* reserved */ + if (option_debug > 1) + ast_log(LOG_DEBUG, "cid info:#2=%X\n", cid->rawdata[x]); break ; - case 0x09: /* dialed number */ - /* length */ - res = cid->rawdata[x++]; - /* dialed number */ - x += res; + } + x++; + break ; + case 0x04: /* no callerid reason */ + /* length */ + x++; + /* no callerid reason code */ + switch (cid->rawdata[x]) { + case 'P': /* caller id denied by user */ + case 'O': /* service not available */ + case 'C': /* pay phone */ + case 'S': /* service congested */ + cid->flags |= CID_UNKNOWN_NUMBER; + if (option_debug > 1) + ast_log(LOG_DEBUG, "no cid reason:%c\n",cid->rawdata[x]); break ; - case 0x22: /* dialed number additional information */ - /* length */ - x++; - /* number type */ - switch (cid->rawdata[x]) { - case 0x00: /* unknown */ - case 0x01: /* international number */ - case 0x02: /* domestic number */ - case 0x03: /* network */ - case 0x04: /* local call */ - case 0x06: /* short dial number */ - case 0x07: /* reserved */ - default: /* reserved */ - ast_log(LOG_NOTICE, "did info:#1=%X\n", cid->rawdata[x]); - break ; - } - x++; - /* numbering plan octed 4 */ - x++; - /* numbering plan octed 5 */ - switch (cid->rawdata[x]) { - case 0x00: /* unknown */ - case 0x01: /* recommendation E.164 ISDN */ - case 0x03: /* recommendation X.121 */ - case 0x04: /* telex dial plan */ - case 0x08: /* domestic dial plan */ - case 0x09: /* private dial plan */ - case 0x05: /* reserved */ - default: /* reserved */ - ast_log(LOG_NOTICE, "did info:#2=%X\n", cid->rawdata[x]); - break ; - } - x++; - break ; + } + x++; + break ; + case 0x09: /* dialed number */ + /* length */ + res = cid->rawdata[x++]; + /* dialed number */ + x += res; + break ; + case 0x22: /* dialed number additional information */ + /* length */ + x++; + /* number type */ + switch (cid->rawdata[x]) { + case 0x00: /* unknown */ + case 0x01: /* international number */ + case 0x02: /* domestic number */ + case 0x03: /* network */ + case 0x04: /* local call */ + case 0x06: /* short dial number */ + case 0x07: /* reserved */ + default: /* reserved */ + if (option_debug > 1) + ast_log(LOG_NOTICE, "did info:#1=%X\n", cid->rawdata[x]); + break ; + } + x++; + /* numbering plan octed 4 */ + x++; + /* numbering plan octed 5 */ + switch (cid->rawdata[x]) { + case 0x00: /* unknown */ + case 0x01: /* recommendation E.164 ISDN */ + case 0x03: /* recommendation X.121 */ + case 0x04: /* telex dial plan */ + case 0x08: /* domestic dial plan */ + case 0x09: /* private dial plan */ + case 0x05: /* reserved */ + default: /* reserved */ + if (option_debug > 1) + ast_log(LOG_DEBUG, "did info:#2=%X\n", cid->rawdata[x]); + break ; + } + x++; + break ; } } return 1; @@ -722,7 +730,7 @@ static int callerid_genmsg(char *msg, int size, char *number, char *name, int fl res = snprintf(ptr, size, "\002%c", i); size -= res; ptr += res; - for (x=0;x