kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-03 11:11:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

ARI: Fixed crash that occurred when updating a bridge when the optional query parameter 'name' was not supplied.

Browse Source 
Prior to this changeset, posting to the: /ari/bridges/{bridgeId} endpoint without specifying a value for the [name] query parameter, would crash Asterisk if the bridge you are attempting to create (or update) had the same ID as an existing bridge. The internal mechanism of the POST operation interpreted a null value for name, thus resulting in an error condition that crashed Asterisk.

ASTERISK-24560 #close
Reported By: Kinsey Moore

Review: https://reviewboard.asterisk.org/r/4349/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@430818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Ashley Sanders
2015-01-20 16:51:44 +00:00
parent 6af6a216a1
commit a7ba8a58a8
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
res/ari/resource_bridges.c
View File

@@ -949,16 +949,18 @@ void ast_ari_bridges_create_or_update_with_id(struct ast_variable *headers,
if (bridge) {
/* update */
if (strcmp(args->name, bridge->name)) {
if (!ast_strlen_zero(args->name)) {
if (!strcmp(args->name, bridge->name)) {
ast_ari_response_error(
response, 500, "Internal Error",
"Changing bridge name is not implemented");
return;
}
}
if (!ast_strlen_zero(args->type)) {
ast_ari_response_error(
response, 500, "Internal Error",
"Changing bridge type is not implemented");
"Supplying a bridge type when updating a bridge is not allowed.");
return;
}
ast_ari_response_ok(response,