kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct fix for issue #16268... the reporter's original patch was very close to correct.

Browse Source 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230839 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Kevin P. Fleming
2009-11-23 15:09:24 +00:00
parent 800a1df304
commit afd2b5e203
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
channels/chan_sip.c
View File

@@ -636,7 +636,7 @@ struct sip_request {
char *line[SIP_MAX_LINES];
char data[SIP_MAX_PACKET];
unsigned int sdp_start; /*!< the line number where the SDP begins */
unsigned int sdp_end; /*!< the line number where the SDP ends */
unsigned int sdp_count; /*!< the number of lines of SDP */
AST_LIST_ENTRY(sip_request) next;
};
@@ -4367,26 +4367,31 @@ static const char *get_sdp_iterate(int *start, struct sip_request *req, const ch
{
int len = strlen(name);
while (*start <= req->sdp_end) {
while (*start < (req->sdp_start + req->sdp_count)) {
const char *r = get_body_by_line(req->line[(*start)++], name, len);
if (r[0] != '\0')
return r;
}
/* if the line was not found, ensure that *start points past the SDP */
(*start)++;
return "";
}
/*! \brief Fetches the next valid SDP line between the 'start' line
* and the 'stop' line (*excluding* the 'stop' line). Returns the type
* ('a', 'c', ...) and matching line in reference 'start' is updated with the
* next line number.
* (inclusive) and the 'stop' line (exclusive). Returns the type
* ('a', 'c', ...) and matching line in reference 'start' is updated
* with the next line number.
*/
static char get_sdp_line(int *start, int stop, struct sip_request *req, const char **value)
{
char type = '\0';
const char *line = NULL;
if (stop > req->sdp_end || stop < req->sdp_start) stop = req->sdp_end + 1;
if (stop > (req->sdp_start + req->sdp_count)) {
stop = req->sdp_start + req->sdp_count;
}
while (*start < stop) {
line = req->line[(*start)++];
@@ -5121,7 +5126,7 @@ static int parse_request(struct sip_request *req)
\param req the SIP request to process
\return 1 if SDP found, 0 if not found
Also updates req->sdp_start and req->sdp_end to indicate where the SDP
Also updates req->sdp_start and req->sdp_count to indicate where the SDP
lives in the message body.
*/
static int find_sdp(struct sip_request *req)
@@ -5154,7 +5159,7 @@ static int find_sdp(struct sip_request *req)
/* if the body contains only SDP, this is easy */
if (!strncasecmp(content_type, "application/sdp", 15)) {
req->sdp_start = 0;
req->sdp_end = req->lines;
req->sdp_count = req->lines;
return req->lines ? 1 : 0;
}
@@ -5193,7 +5198,7 @@ static int find_sdp(struct sip_request *req)
for (x = 0; x < (req->lines ); x++) {
if(!strncasecmp(req->line[x], boundary, strlen(boundary))){
if(found_application_sdp && found_end_of_headers){
req->sdp_end = x-1;
req->sdp_count = (x - 1) - req->sdp_start;
return 1;
}
found_application_sdp = FALSE;
@@ -5209,7 +5214,7 @@ static int find_sdp(struct sip_request *req)
}
}
if(found_application_sdp && found_end_of_headers) {
req->sdp_end = x;
req->sdp_count = x - req->sdp_start;
return TRUE;
}
return FALSE;