kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 07:35:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make some notes about common usage of pbx_builtin_getvar_helper() that is not

Browse Source 
thread-safe.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111909 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Russell Bryant
2008-03-28 22:50:46 +00:00
parent 16b2720cd4
commit afd8783577
2 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
doc/janitor-projects.txt
View File

@@ -1,3 +1,15 @@
-- There a bunch of places where the result of pbx_builtin_getvar_helper()
gets stored and used. This is not threadsafe. This code should be replaced
with the following thread-safe version:
const char *var;
ast_channel_lock(chan);
if ((var = pbx_builtin_getvar_helper(chan, "MYVAR"))) {
var = ast_strdupa(var);
}
ast_channel_unlock(chan);
-- Convert all existing uses of astobj.h to astobj2.h -- Convert all existing uses of astobj.h to astobj2.h
-- (chan_sip already in progress in a branch) -- (chan_sip already in progress in a branch)

14
include/asterisk/pbx.h
View File

@@ -800,6 +800,20 @@ int pbx_builtin_serialize_variables(struct ast_channel *chan, struct ast_str **b
/*! /*!
* \note Will lock the channel. * \note Will lock the channel.
*
* \note This function will return a pointer to the buffer inside the channel
* variable. This value should only be accessed with the channel locked. If
* the value needs to be kept around, it should be done by using the following
* thread-safe code:
* \code
* const char *var;
*
* ast_channel_lock(chan);
* if ((var = pbx_builtin_getvar_helper(chan, "MYVAR"))) {
* var = ast_strdupa(var);
* }
* ast_channel_unlock(chan);
* \endcode
*/ */
const char *pbx_builtin_getvar_helper(struct ast_channel *chan, const char *name); const char *pbx_builtin_getvar_helper(struct ast_channel *chan, const char *name);