kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a potential memory leak of the local_pvt struct when ast_channel allocation

Browse Source 
fails.  Also, in passing, centralize the code necessary to destroy a local_pvt.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@105568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Russell Bryant
2008-03-03 17:05:16 +00:00
parent 9c5af082ca
commit b3c0e042d4
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
channels/chan_local.c
View File

@@ -150,6 +150,13 @@ static int local_devicestate(void *data)
return AST_DEVICE_UNKNOWN;
}
static struct local_pvt *local_pvt_destroy(struct local_pvt *pvt)
{
ast_mutex_destroy(&pvt->lock);
free(pvt);
return NULL;
}
static int local_queue_frame(struct local_pvt *p, int isoutbound, struct ast_frame *f, struct ast_channel *us)
{
struct ast_channel *other = NULL;
@@ -163,8 +170,7 @@ static int local_queue_frame(struct local_pvt *p, int isoutbound, struct ast_fra
/* We had a glare on the hangup. Forget all this business,
return and destroy p. */
ast_mutex_unlock(&p->lock);
ast_mutex_destroy(&p->lock);
free(p);
p = local_pvt_destroy(p);
return -1;
}
if (!other) {
@@ -540,8 +546,7 @@ static int local_hangup(struct ast_channel *ast)
ast_mutex_unlock(&p->lock);
/* And destroy */
if (!glaredetect) {
ast_mutex_destroy(&p->lock);
free(p);
p = local_pvt_destroy(p);
}
return 0;
}
@@ -587,9 +592,7 @@ static struct local_pvt *local_alloc(const char *data, int format)
if (!ast_exists_extension(NULL, tmp->context, tmp->exten, 1, NULL)) {
ast_log(LOG_NOTICE, "No such extension/context %s@%s creating local channel\n", tmp->exten, tmp->context);
ast_mutex_destroy(&tmp->lock);
free(tmp);
tmp = NULL;
tmp = local_pvt_destroy(tmp);
} else {
/* Add to list */
AST_LIST_LOCK(&locals);
@@ -662,7 +665,6 @@ static struct ast_channel *local_new(struct local_pvt *p, int state)
return tmp;
}
/*! \brief Part of PBX interface */
static struct ast_channel *local_request(const char *type, int format, void *data, int *cause)
{
@@ -670,8 +672,10 @@ static struct ast_channel *local_request(const char *type, int format, void *dat
struct ast_channel *chan = NULL;
/* Allocate a new private structure and then Asterisk channel */
if ((p = local_alloc(data, format)))
chan = local_new(p, AST_STATE_DOWN);
if ((p = local_alloc(data, format))) {
if (!(chan = local_new(p, AST_STATE_DOWN)))
p = local_pvt_destroy(p);
}
return chan;
}