From b98153bf45e45ff90486c12430b9cc627f8684a7 Mon Sep 17 00:00:00 2001 From: Tilghman Lesher Date: Wed, 12 Jan 2011 00:26:39 +0000 Subject: [PATCH] Call execl() directly for a better solution for paths with spaces. (closes issue #18600) Reported by: ebroad Patches: 20110111__issue18600__2.diff.txt uploaded by tilghman (license 14) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@301402 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/file.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/main/file.c b/main/file.c index a5c99d55a9..c37937be19 100644 --- a/main/file.c +++ b/main/file.c @@ -310,11 +310,9 @@ static void filestream_destructor(void *arg) ast_translator_free_path(f->trans); if (f->realfilename && f->filename) { - size = strlen(f->filename) + strlen(f->realfilename) + 15; - cmd = alloca(size); - memset(cmd,0,size); - snprintf(cmd, size, "/bin/mv -f \"%s\" \"%s\"", f->filename, f->realfilename); - ast_safe_system(cmd); + if (ast_safe_fork(0) == 0) { + execl("/bin/mv", "mv", "-f", f->filename, f->realfilename, SENTINEL); + } } if (f->filename)