From bdea273046ca3808f1e7647146d3a12d95a94cac Mon Sep 17 00:00:00 2001 From: Joshua Colp Date: Wed, 5 Apr 2006 20:01:19 +0000 Subject: [PATCH] Unlock channel on failure so that ast_mutex_destroy doesn't throw a fit (issue #6647 reported by casper) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@17702 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- pbx.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/pbx.c b/pbx.c index b9662ad3dd..96707fad64 100644 --- a/pbx.c +++ b/pbx.c @@ -5025,8 +5025,10 @@ int ast_pbx_outgoing_exten(const char *type, int format, void *data, int timeout } else { if (ast_pbx_start(chan)) { ast_log(LOG_ERROR, "Unable to start PBX on %s\n", chan->name); - if (channel) + if (channel) { *channel = NULL; + ast_mutex_unlock(&chan->lock); + } ast_hangup(chan); res = -1; } @@ -5042,13 +5044,15 @@ int ast_pbx_outgoing_exten(const char *type, int format, void *data, int timeout ast_cdr_failed(chan->cdr); } - if (channel) + if (channel) { *channel = NULL; + ast_mutex_unlock(&chan->lock); + } ast_hangup(chan); } } - if(res < 0) { /* the call failed for some reason */ + if (res < 0) { /* the call failed for some reason */ if (*reason == 0) { /* if the call failed (not busy or no answer) * update the cdr with the failed message */ cdr_res = ast_pbx_outgoing_cdr_failed(); @@ -5107,8 +5111,10 @@ int ast_pbx_outgoing_exten(const char *type, int format, void *data, int timeout if (ast_pthread_create(&as->p, &attr, async_wait, as)) { ast_log(LOG_WARNING, "Failed to start async wait\n"); free(as); - if (channel) + if (channel) { *channel = NULL; + ast_mutex_unlock(&chan->lock); + } ast_hangup(chan); res = -1; goto outgoing_exten_cleanup;