CDR Mysql fixes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1279 65c4cc65-6c06-0410-ace0-fbb531ad65f3

cdr/cdr_mysql.c

@@ -27,214 +27,212 @@
 #include <time.h>
 
 #include <mysql.h>
+#include <mysql/errmsg.h>
 
 #define DATE_FORMAT "%Y-%m-%d %T"
 
 static char *desc = "MySQL CDR Backend";
 static char *name = "mysql";
 static char *config = "cdr_mysql.conf";
+static char *hostname = NULL, *dbname = NULL, *dbuser = NULL, *password = NULL;
+static int connected = 0;
 
-static MYSQL *mysql;
+static pthread_mutex_t mysql_lock = AST_MUTEX_INITIALIZER;
+
+static MYSQL mysql;
 
 static int mysql_log(struct ast_cdr *cdr)
 {
-  struct tm tm;
+	struct tm tm;
-  struct timeval tv;
+	struct timeval tv;
-  struct timezone tz;
+	char sqlcmd[2048], timestr[128];
-  char *sqlcmd, timestr[128];
+	time_t t;
-  time_t t;
 
+	ast_pthread_mutex_lock(&mysql_lock);
 
-  sqlcmd = (char *)malloc(2048);
+	memset(sqlcmd,0,2048);
-  memset(sqlcmd,0,2048);
 
+	gettimeofday(&tv,NULL);
+	t = tv.tv_sec;
+	localtime_r(&t,&tm);
+	strftime(timestr,128,DATE_FORMAT,&tm);
 
-  gettimeofday(&tv,&tz);
+	if ((!connected) && hostname && dbuser && password && dbname) {
-  t = tv.tv_sec;
+		/* Attempt to connect */
-  localtime_r(&t,&tm);
+		mysql_init(&mysql);
-  strftime(timestr,128,DATE_FORMAT,&tm);
+		if (mysql_real_connect(&mysql, hostname, dbuser, password, dbname, 0, NULL, 0)) {
+			connected = 1;
+		} else {
+			ast_log(LOG_ERROR, "cdr_mysql: cannot connect to database %s.  Call will not be logged\n", hostname);
+		}
+	} else {
+		/* Long connection - ping the server */
+		int error;
+		if ((error = mysql_ping(&mysql))) {
+			connected = 0;
+			switch (error) {
+				case CR_SERVER_GONE_ERROR:
+					ast_log(LOG_ERROR, "cdr_mysql: Server has gone away\n");
+					break;
+				default:
+					ast_log(LOG_ERROR, "cdr_mysql: Unknown connection error\n");
+			}
+		}
+	}
 
-
+	if (connected) {
-  ast_log(LOG_DEBUG,"cdr_mysql: inserting a CDR record.\n");
+		ast_log(LOG_DEBUG,"cdr_mysql: inserting a CDR record.\n");
 #ifdef MYSQL_LOGUNIQUEID
-  sprintf(sqlcmd,"INSERT INTO cdr (calldate,clid,src,dst,dcontext,channel,dstchannel,lastapp,lastdata,duration,billsec,disposition,amaflags,accountcode,uniqueid) VALUES ('%s','%s','%s','%s','%s', '%s','%s','%s','%s',%i,%i,'%s',%i,'%s','%s')",timestr,cdr->clid,cdr->src, cdr->dst, cdr->dcontext,cdr->channel, cdr->dstchannel, cdr->lastapp, cdr->lastdata,cdr->duration,cdr->billsec,ast_cdr_disp2str(cdr->disposition),cdr->amaflags, cdr->accountcode, cdr->uniqueid);
+		sprintf(sqlcmd,"INSERT INTO cdr (calldate,clid,src,dst,dcontext,channel,dstchannel,lastapp,lastdata,duration,billsec,disposition,amaflags,accountcode,uniqueid) VALUES ('%s','%s','%s','%s','%s', '%s','%s','%s','%s',%i,%i,'%s',%i,'%s','%s')",timestr,cdr->clid,cdr->src, cdr->dst, cdr->dcontext,cdr->channel, cdr->dstchannel, cdr->lastapp, cdr->lastdata,cdr->duration,cdr->billsec,ast_cdr_disp2str(cdr->disposition),cdr->amaflags, cdr->accountcode, cdr->uniqueid);
 #else
-  sprintf(sqlcmd,"INSERT INTO cdr (calldate,clid,src,dst,dcontext,channel,dstchannel,lastapp,lastdata,duration,billsec,disposition,amaflags,accountcode) VALUES ('%s','%s','%s','%s','%s', '%s','%s','%s','%s',%i,%i,'%s',%i,'%s')",timestr,cdr->clid,cdr->src, cdr->dst, cdr->dcontext,cdr->channel, cdr->dstchannel, cdr->lastapp, cdr->lastdata,cdr->duration,cdr->billsec,ast_cdr_disp2str(cdr->disposition),cdr->amaflags, cdr->accountcode);
+		sprintf(sqlcmd,"INSERT INTO cdr (calldate,clid,src,dst,dcontext,channel,dstchannel,lastapp,lastdata,duration,billsec,disposition,amaflags,accountcode) VALUES ('%s','%s','%s','%s','%s', '%s','%s','%s','%s',%i,%i,'%s',%i,'%s')",timestr,cdr->clid,cdr->src, cdr->dst, cdr->dcontext,cdr->channel, cdr->dstchannel, cdr->lastapp, cdr->lastdata,cdr->duration,cdr->billsec,ast_cdr_disp2str(cdr->disposition),cdr->amaflags, cdr->accountcode);
 #endif  
-  ast_log(LOG_DEBUG,"cdr_mysql: SQL command as follows:  %s\n",sqlcmd);
+		ast_log(LOG_DEBUG,"cdr_mysql: SQL command as follows:  %s\n",sqlcmd);
 	
-  if (mysql_real_query(mysql,sqlcmd,strlen(sqlcmd)))
+		if (mysql_real_query(&mysql,sqlcmd,strlen(sqlcmd))) {
-  {
+			ast_log(LOG_ERROR,"Failed to insert into database.");
-      ast_log(LOG_ERROR,"Failed to insert into database.");
+			ast_pthread_mutex_unlock(&mysql_lock);
-      free(sqlcmd);
+			return -1;
-      return -1;
+		}
-  }
+	}
-  free(sqlcmd);
+	ast_pthread_mutex_unlock(&mysql_lock);
-  return 0;
+	return 0;
 }
 
-
-
 char *description(void)
 {
-  return desc;
+	return desc;
 }
 
 int unload_module(void)
 { 
-
+	if (connected) {
-  mysql_close(mysql);
+		mysql_close(&mysql);
-  ast_cdr_unregister(name);
+		connected = 0;
-  return 0;
+	}
+	if (hostname) {
+		free(hostname);
+		hostname = NULL;
+	}
+	if (dbname) {
+		free(dbname);
+		dbname = NULL;
+	}
+	if (dbuser) {
+		free(dbuser);
+		dbuser = NULL;
+	}
+	if (password) {
+		free(password);
+		password = NULL;
+	}
+	ast_cdr_unregister(name);
+	return 0;
 }
 
 int load_module(void)
 {
-  int res;
+	int res;
-  struct ast_config *cfg;
+	struct ast_config *cfg;
-  struct ast_variable *var;
+	struct ast_variable *var;
+	char *tmp;
 
-  char *hostname, *dbname, *dbuser, *password;
+	cfg = ast_load(config);
+	if (!cfg) {
+		ast_log(LOG_WARNING, "Unable to load config for mysql CDR's: %s\n", config);
+		return 0;
+	}
 	
-  cfg = ast_load(config);
+	var = ast_variable_browse(cfg, "global");
-  if (!cfg) {
+	if (!var) {
-    ast_log(LOG_WARNING, "Unable to load config for mysql CDR's: %s\n", config);
+		/* nothing configured */
-    return 0;
+		return 0;
-  }
+	}
 
-  var = ast_variable_browse(cfg, "global");
+	tmp = ast_variable_retrieve(cfg,"global","hostname");
-  if (!var) {
+	hostname = malloc(strlen(tmp) + 1);
-    /* nothing configured */
+	if ((tmp != NULL) && (hostname != NULL)) {
-    return 0;
+		strcpy(hostname,tmp);
-  }
+	} else if (tmp == NULL) {
+		ast_log(LOG_ERROR,"Database server hostname not specified.\n");
+		return -1;
+	} else {
+		ast_log(LOG_ERROR,"Out of memory error.\n");
+		return -1;
+	}
 
-  hostname = ast_variable_retrieve(cfg,"global","hostname");
+	tmp = ast_variable_retrieve(cfg,"global","dbname");
-  dbname = ast_variable_retrieve(cfg,"global","dbname");
+	dbname = malloc(strlen(tmp) + 1);
-  dbuser = ast_variable_retrieve(cfg,"global","user");
+	if ((tmp != NULL) && (dbname != NULL)) {
-  password = ast_variable_retrieve(cfg,"global","password");
+		strcpy(dbname,tmp);
-  ast_log(LOG_DEBUG,"cdr_mysql: got hostname of %s\n",hostname);
+	} else if (tmp == NULL) {
-  ast_log(LOG_DEBUG,"cdr_mysql: got user of %s\n",dbuser);
+		ast_log(LOG_ERROR,"Database dbname not specified.\n");
-  ast_log(LOG_DEBUG,"cdr_mysql: got dbname of %s\n",dbname);
+		return -1;
-  ast_log(LOG_DEBUG,"cdr_mysql: got password of %s\n",password);
+	} else {
+		ast_log(LOG_ERROR,"Out of memory error.\n");
+		return -1;
+	}
 
-  if (hostname == NULL)
+	tmp = ast_variable_retrieve(cfg,"global","user");
-    {
+	dbuser = malloc(strlen(tmp) + 1);
-      ast_log(LOG_ERROR,"Database server hostname not specified.\n");
+	if ((tmp != NULL) && (dbuser != NULL)) {
-      return -1;
+		strcpy(dbuser,tmp);
-    }
+	} else if (tmp == NULL) {
-  if (dbuser == NULL)
+		ast_log(LOG_ERROR,"Database dbuser not specified.\n");
-    {
+		return -1;
-      ast_log(LOG_ERROR,"Database dbuser not specified.\n");
+	} else {
-      return -1;
+		ast_log(LOG_ERROR,"Out of memory error.\n");
-    }
+		return -1;
-  if (dbname == NULL)
+	}
-    {
-      ast_log(LOG_ERROR,"Database dbname not specified.\n");
-      return -1;
-    }
-  if (password == NULL)
-    {
-      ast_log(LOG_ERROR,"Database password not specified.\n");
-      return -1;
-    }
 
+	tmp = ast_variable_retrieve(cfg,"global","password");
+	password = malloc(strlen(tmp) + 1);
+	if ((tmp != NULL) && (password != NULL)) {
+		strcpy(password,tmp);
+	} else if (tmp == NULL) {
+		ast_log(LOG_ERROR,"Database password not specified.\n");
+		return -1;
+	} else {
+		ast_log(LOG_ERROR,"Out of memory error.\n");
+		return -1;
+	}
 
-  mysql = mysql_init(NULL);
+	ast_destroy(cfg);
 
-  mysql = mysql_real_connect(mysql, hostname, dbuser, password, dbname, 0, NULL, 0);
+	ast_log(LOG_DEBUG,"cdr_mysql: got hostname of %s\n",hostname);
+	ast_log(LOG_DEBUG,"cdr_mysql: got user of %s\n",dbuser);
+	ast_log(LOG_DEBUG,"cdr_mysql: got dbname of %s\n",dbname);
+	ast_log(LOG_DEBUG,"cdr_mysql: got password of %s\n",password);
 
-  if (mysql == NULL) {
+	mysql_init(&mysql);
-    ast_log(LOG_ERROR, "Failed to connect to mysql database.\n");
-    return -1;
-  } else {
-    ast_log(LOG_DEBUG,"Successfully connected to MySQL database.\n");
-  }
 
+	if (!mysql_real_connect(&mysql, hostname, dbuser, password, dbname, 0, NULL, 0)) {
+		ast_log(LOG_ERROR, "Failed to connect to mysql database %s on %s.\n", dbname, hostname);
+		connected = 0;
+	} else {
+		ast_log(LOG_DEBUG,"Successfully connected to MySQL database.\n");
+		connected = 1;
+	}
 
-  res = ast_cdr_register(name, desc, mysql_log);
+	res = ast_cdr_register(name, desc, mysql_log);
-  if (res) {
+	if (res) {
-    ast_log(LOG_ERROR, "Unable to register MySQL CDR handling\n");
+		ast_log(LOG_ERROR, "Unable to register MySQL CDR handling\n");
-  }
+	}
-  return res;
+	return res;
 }
 
 int reload(void)
 {
-
+	unload_module();
-  struct ast_config *cfg;
+	return load_module();
-  struct ast_variable *var;
-
-  char *hostname, *dbname, *password, *dbuser;
-  
-  mysql_close(mysql);
-
-
-  cfg = ast_load(config);
-  if (!cfg) {
-    ast_log(LOG_WARNING, "Unable to load MySQL CDR config %s\n", config);
-    return 0;
-  }
-  
-  var = ast_variable_browse(cfg, "global");
-  if (!var) {
-    /* nothing configured */
-    return 0;
-  }
-
-  hostname = ast_variable_retrieve(cfg,"global","hostname");
-  dbname = ast_variable_retrieve(cfg,"global","dbname");
-  dbuser = ast_variable_retrieve(cfg,"global","user");
-  password = ast_variable_retrieve(cfg,"global","password");
-  ast_log(LOG_DEBUG,"cdr_mysql: got hostname of %s\n",hostname);
-  ast_log(LOG_DEBUG,"cdr_mysql: got dbname of %s\n",dbname);
-  ast_log(LOG_DEBUG,"cdr_mysql: got dbuser of %s\n",dbuser);
-  ast_log(LOG_DEBUG,"cdr_mysql: got password of %s\n",password);
-
-  if (hostname == NULL)
-    {
-      ast_log(LOG_ERROR,"Database server hostname not specified.\n");
-      return -1;
-    }
-  if (dbname == NULL)
-    {
-      ast_log(LOG_ERROR,"Database dbname not specified.\n");
-      return -1;
-    }
-  if (dbuser == NULL)
-    {
-      ast_log(LOG_ERROR,"Database dbuser not specified.\n");
-      return -1;
-    }
-  
-  if (password == NULL)
-    {
-      ast_log(LOG_ERROR,"Database password not specified.\n");
-      return -1;
-    }
-  
- mysql = mysql_init(NULL);
- 
- mysql = mysql_real_connect(mysql, hostname, dbuser, password, dbname, 0, NULL, 0);
- 
- if (mysql == NULL) {
-   ast_log(LOG_ERROR, "Failed to connect to mysql database.\n");
-   return -1;
- } else {
-   ast_log(LOG_DEBUG,"Successfully connected to MySQL database.\n");
- }
- 
-
-
-
-  return 0;
 }
 
 int usecount(void)
 {
-  return 0;
+	return connected;
 }
 
 char *key()
 {
-  return ASTERISK_GPL_KEY;
+	return ASTERISK_GPL_KEY;
 }