kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-03 19:16:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_pjsip/res_pjsip_callerid: NULL check on caller id name string

Browse Source 
It's possible for a name in a party id structure to be marked as valid, but the
name string itself be NULL (for instance this is possible to do by using the
dialplan CALLERID function). There were a couple of places where the name was
validated, but the string itself was not checked before passing it to functions
like 'strlen'. This of course caused a crashed.

This patch adds in a NULL check before attempting to pass it into a function
that is not NULL tolerant.

ASTERISK-25823 #close

Change-Id: Iaa6ffe9d92f598fe9e3c8ae373fadbe3dfbf1d4a
This commit is contained in:
Kevin Harwell
2017-04-26 14:20:00 -05:00
parent d2bb9f21d4
commit c853cfdc7c
2 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
res/res_pjsip.c
View File

@@ -4380,11 +4380,15 @@ void ast_sip_modify_id_header(pj_pool_t *pool, pjsip_fromto_hdr *id_hdr, const s
id_uri = pjsip_uri_get_uri(id_name_addr->uri);
if (id->name.valid) {
if (!ast_strlen_zero(id->name.str)) {
int name_buf_len = strlen(id->name.str) * 2 + 1;
char *name_buf = ast_alloca(name_buf_len);
ast_escape_quoted(id->name.str, name_buf, name_buf_len);
pj_strdup2(pool, &id_name_addr->display, name_buf);
} else {
pj_strdup2(pool, &id_name_addr->display, NULL);
}
}
if (id->number.valid) {

7
res/res_pjsip_caller_id.c
View File

@@ -436,7 +436,7 @@ static pjsip_fromto_hdr *create_new_id_hdr(const pj_str_t *hdr_name, pjsip_fromt
id_name_addr = pjsip_uri_clone(tdata->pool, base->uri);
id_uri = pjsip_uri_get_uri(id_name_addr->uri);
if (id->name.valid) {
if (id->name.valid && !ast_strlen_zero(id->name.str)) {
int name_buf_len = strlen(id->name.str) * 2 + 1;
char *name_buf = ast_alloca(name_buf_len);
@@ -450,7 +450,12 @@ static pjsip_fromto_hdr *create_new_id_hdr(const pj_str_t *hdr_name, pjsip_fromt
pj_strdup2(tdata->pool, &id_name_addr->display, NULL);
}
if (id->number.valid) {
pj_strdup2(tdata->pool, &id_uri->user, id->number.str);
} else {
/* Similar to name, make sure the number is also cleared when invalid */
pj_strdup2(tdata->pool, &id_uri->user, NULL);
}
id_hdr->uri = (pjsip_uri *) id_name_addr;
return id_hdr;