mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-13 00:04:53 +00:00
revert my changes that converted the jb on the channel to be dynamically
allocated. These changes caused crashes when using a channel type that did not support the jitterbuffer. Instead of fixing why it's crashing, I'm going to implement this in a better way next week. The way I did it caused a jitterbuffer to be allocated on every channel where the channel type supported jitterbuffers, even if they were disabled. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35746 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -2516,6 +2516,10 @@ static struct ast_channel *skinny_new(struct skinny_line *l, int state)
|
||||
if (l->amaflags)
|
||||
tmp->amaflags = l->amaflags;
|
||||
|
||||
ast_mutex_lock(&usecnt_lock);
|
||||
usecnt++;
|
||||
ast_mutex_unlock(&usecnt_lock);
|
||||
ast_update_use_count();
|
||||
tmp->callgroup = l->callgroup;
|
||||
tmp->pickupgroup = l->pickupgroup;
|
||||
ast_string_field_set(tmp, call_forward, l->call_forward);
|
||||
@@ -2526,29 +2530,18 @@ static struct ast_channel *skinny_new(struct skinny_line *l, int state)
|
||||
tmp->priority = 1;
|
||||
tmp->adsicpe = AST_ADSI_UNAVAILABLE;
|
||||
|
||||
/* Configure the new channel jb */
|
||||
if (sub->rtp) {
|
||||
if (ast_jb_configure(tmp, &global_jbconf)) {
|
||||
ast_hangup(tmp);
|
||||
sub->owner = NULL;
|
||||
return NULL;
|
||||
}
|
||||
}
|
||||
if (state != AST_STATE_DOWN) {
|
||||
if (ast_pbx_start(tmp)) {
|
||||
ast_log(LOG_WARNING, "Unable to start PBX on %s\n", tmp->name);
|
||||
ast_hangup(tmp);
|
||||
sub->owner = NULL;
|
||||
return NULL;
|
||||
tmp = NULL;
|
||||
}
|
||||
}
|
||||
|
||||
/* Configure the new channel jb */
|
||||
if (tmp && sub->rtp)
|
||||
ast_jb_configure(tmp, &global_jbconf);
|
||||
}
|
||||
|
||||
ast_mutex_lock(&usecnt_lock);
|
||||
usecnt++;
|
||||
ast_mutex_unlock(&usecnt_lock);
|
||||
ast_update_use_count();
|
||||
|
||||
return tmp;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user