From cc212c962e9037e65d9be200e186b7cc9a589fc3 Mon Sep 17 00:00:00 2001 From: Mark Michelson Date: Wed, 2 Jul 2008 21:10:00 +0000 Subject: [PATCH] Merged revisions 127566 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r127566 | mmichelson | 2008-07-02 16:09:18 -0500 (Wed, 02 Jul 2008) | 4 lines Add a janitor project to use ARRAY_LEN instead of in-line sizeof() and division. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@127567 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- doc/janitor-projects.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/janitor-projects.txt b/doc/janitor-projects.txt index 2370176336..839d579459 100644 --- a/doc/janitor-projects.txt +++ b/doc/janitor-projects.txt @@ -28,3 +28,11 @@ -- Audit all channel/res/app/etc. modules to ensure that they do not register any entrypoints with the Asterisk core until after they are ready to service requests; all config file reading/processing, structure allocation, etc. must be completed before Asterisk is made aware of any services the module offers. -- Ensure that Realtime-enabled modules do not depend on the order of columns returned by the database lookup (example: outboundproxy and host settings in chan_sip). + + -- There are several places in the code where the length of arrays is calculated in-line with sizeof() and division. A common place to find this is in for loops, like this: + + for (i = 0; i < sizeof(array)/sizeof(array[0]); i++) + + There is a macro in utils.h called ARRAY_LEN which should be used instead for readability's sake. + + for (i = 0; i < ARRAY_LEN(array); i++)