Since powerof() can return an error condition, it's foolhardy not to detect and

deal with that condition.
(Related to issue #13240)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@135915 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Tilghman Lesher
2008-08-06 03:24:56 +00:00
parent 1a0c9841dd
commit cd17593356

View File

@@ -273,7 +273,12 @@ struct ast_trans_pvt *ast_translator_build_path(int dest, int source)
source = powerof(source);
dest = powerof(dest);
if (source == -1 || dest == -1) {
ast_log(LOG_WARNING, "No translator path: (%s codec is not valid)\n", source == -1 ? "starting" : "ending");
return NULL;
}
AST_LIST_LOCK(&translators);
while (source != dest) {
@@ -694,6 +699,10 @@ int __ast_register_translator(struct ast_translator *t, struct ast_module *mod)
t->dstfmt = powerof(t->dstfmt);
t->active = 1;
if (t->srcfmt == -1 || t->dstfmt == -1) {
ast_log(LOG_WARNING, "Invalid translator path: (%s codec is not valid)\n", t->srcfmt == -1 ? "starting" : "ending");
return -1;
}
if (t->plc_samples) {
if (t->buffer_samples < t->plc_samples) {
ast_log(LOG_WARNING, "plc_samples %d buffer_samples %d\n",
@@ -868,6 +877,10 @@ unsigned int ast_translate_path_steps(unsigned int dest, unsigned int src)
src = powerof(src);
dest = powerof(dest);
if (src == -1 || dest == -1) {
ast_log(LOG_WARNING, "No translator path: (%s codec is not valid)\n", src == -1 ? "starting" : "ending");
return -1;
}
AST_LIST_LOCK(&translators);
if (tr_matrix[src][dest].step)