Update to Coding Guidelines

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@156653 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Brandon Kruse
2008-11-13 19:26:21 +00:00
parent f077cc197d
commit dbc2ed5e21

View File

@@ -1245,17 +1245,17 @@ static enum error_type handle_updates(struct mansession *s, const struct message
struct ast_category *category; struct ast_category *category;
struct ast_variable *v; struct ast_variable *v;
for (x = 0; x < 100000; x++) { //100000 = the max number of allowed updates + 1 for (x = 0; x < 100000; x++) { /* 100000 = the max number of allowed updates + 1 */
unsigned int object = 0; unsigned int object = 0;
snprintf(hdr, sizeof(hdr), "Action-%06d", x); snprintf(hdr, sizeof(hdr), "Action-%06d", x);
action = astman_get_header(m, hdr); action = astman_get_header(m, hdr);
if (ast_strlen_zero(action)) // breaks the for loop if no action header if (ast_strlen_zero(action)) /* breaks the for loop if no action header */
break; // this could cause problems if actions come in misnumbered break; /* this could cause problems if actions come in misnumbered */
snprintf(hdr, sizeof(hdr), "Cat-%06d", x); snprintf(hdr, sizeof(hdr), "Cat-%06d", x);
cat = astman_get_header(m, hdr); cat = astman_get_header(m, hdr);
if (ast_strlen_zero(cat)) //every action needs a category if (ast_strlen_zero(cat)) /* every action needs a category */
return UNSPECIFIED_CATEGORY; return UNSPECIFIED_CATEGORY;
snprintf(hdr, sizeof(hdr), "Var-%06d", x); snprintf(hdr, sizeof(hdr), "Var-%06d", x);
@@ -1275,8 +1275,8 @@ static enum error_type handle_updates(struct mansession *s, const struct message
line = astman_get_header(m, hdr); line = astman_get_header(m, hdr);
if (!strcasecmp(action, "newcat")) { if (!strcasecmp(action, "newcat")) {
if (ast_category_get(cfg,cat)) //check to make sure the cat doesn't if (ast_category_get(cfg,cat)) /* check to make sure the cat doesn't */
return FAILURE_NEWCAT; //already exist return FAILURE_NEWCAT; /* already exist */
if (!(category = ast_category_new(cat, dfn, -1))) if (!(category = ast_category_new(cat, dfn, -1)))
return FAILURE_ALLOCATION; return FAILURE_ALLOCATION;
if (ast_strlen_zero(match)) { if (ast_strlen_zero(match)) {