kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-20 12:20:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use strncpy for moving a chunk of memory to another that is overlapping.

Browse Source 
This was found by running Asterisk under valgrind.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@78829 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Russell Bryant
2007-08-09 20:07:59 +00:00
parent 62f661484b
commit dc7af7d5fe
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/app_minivm.c
View File

@@ -2275,11 +2275,11 @@ static char *message_template_parse_emailbody(const char *configuration)
int len = strlen("\n"); int len = strlen("\n");
switch (tmpwrite[1]) { switch (tmpwrite[1]) {
case 'n': case 'n':
strncpy(tmpwrite+len, tmpwrite+2, strlen(tmpwrite+2)+1); memmove(tmpwrite + len, tmpwrite + 2, strlen(tmpwrite + 2) + 1);
strncpy(tmpwrite, "\n", len); strncpy(tmpwrite, "\n", len);
break; break;
case 't': case 't':
strncpy(tmpwrite+len, tmpwrite+2, strlen(tmpwrite+2)+1); memmove(tmpwrite + len, tmpwrite + 2, strlen(tmpwrite + 2) + 1);
strncpy(tmpwrite, "\t", len); strncpy(tmpwrite, "\t", len);
break; break;
default: default: