kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-04 19:35:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ring all queue with more than 255 agents will cause crash.

Browse Source 
1. Create a ring-all queue with 500 permanent agents.
2. Call it.
3. Asterisk will crash.

The watchers array in app_queue.c has a hard limit of 255.  Bounds
checking is not done on this array.  No sane person should put 255 people
in a ring-all queue, but we should not crash anyway.

* Added bounds checking to the watchers array.

JIRA AST-464
JIRA SWP-2903


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@322484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Richard Mudgett
2011-06-08 20:46:55 +00:00
parent 6b2172bea3
commit e0b2c103f6
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/app_queue.c
View File

@@ -3486,7 +3486,9 @@ static struct callattempt *wait_for_answer(struct queue_ent *qe, struct callatte
if (o->stillgoing) { /* Keep track of important channels */ if (o->stillgoing) { /* Keep track of important channels */
stillgoing = 1; stillgoing = 1;
if (o->chan) { if (o->chan) {
if (pos < AST_MAX_WATCHERS) {
watchers[pos++] = o->chan; watchers[pos++] = o->chan;
}
if (!start) if (!start)
start = o; start = o;
else else