mirror of
				https://github.com/asterisk/asterisk.git
				synced 2025-10-31 18:55:19 +00:00 
			
		
		
		
	This rather large commit changes the way modules are loaded.
As partly documented in loader.c and include/asterisk/module.h, modules are now expected to return all of their methods and flags into a structure 'mod_data', and are normally loaded with RTLD_NOW | RTLD_LOCAL, so symbols are resolved immediately and conflicts should be less likely. Only in a small number of cases (res_*, typically) modules are loaded RTLD_GLOBAL, so they can export symbols. The core of the change is only the two files loader.c and include/asterisk/module.h, all the rest is simply adaptation of the existing modules to the new API, a rather mechanical (but believe me, time and finger-consuming!) process whose detail you can figure out by svn diff'ing any single module. Expect some minor compilation issue after this change, please report it on mantis http://bugs.digium.com/view.php?id=6968 so we collect all the feedback in one place. I am just sorry that this change missed SVN version number 20000! git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
		| @@ -190,8 +190,6 @@ static struct ast_frame *lintoilbc_frameout(struct ast_trans_pvt *pvt) | ||||
| 	return ast_trans_frameout(pvt, datalen, samples); | ||||
| } | ||||
|  | ||||
| static struct ast_module_lock me = { .usecnt = -1 }; | ||||
|  | ||||
| static struct ast_translator ilbctolin = { | ||||
| 	.name = "ilbctolin",  | ||||
| 	.srcfmt = AST_FORMAT_ILBC, | ||||
| @@ -201,7 +199,6 @@ static struct ast_translator ilbctolin = { | ||||
| 	.sample = ilbctolin_sample, | ||||
| 	.desc_size = sizeof(struct ilbc_coder_pvt), | ||||
| 	.buf_size = BUFFER_SAMPLES * 2, | ||||
| 	.lockp = &me, | ||||
| }; | ||||
|  | ||||
| static struct ast_translator lintoilbc = { | ||||
| @@ -214,43 +211,35 @@ static struct ast_translator lintoilbc = { | ||||
| 	.sample = lintoilbc_sample, | ||||
| 	.desc_size = sizeof(struct ilbc_coder_pvt), | ||||
| 	.buf_size = (BUFFER_SAMPLES * ILBC_FRAME_LEN + ILBC_SAMPLES - 1) / ILBC_SAMPLES, | ||||
| 	.lockp = &me, | ||||
| }; | ||||
|  | ||||
| int unload_module(void) | ||||
| static int unload_module(void *mod) | ||||
| { | ||||
| 	int res; | ||||
| 	ast_mutex_lock(&me.lock); | ||||
| 	res = ast_unregister_translator(&lintoilbc); | ||||
| 	res |= ast_unregister_translator(&ilbctolin); | ||||
| 	if (me.usecnt) | ||||
| 		res = -1; | ||||
| 	ast_mutex_unlock(&me.lock); | ||||
| 	return res; | ||||
| } | ||||
|  | ||||
| int load_module(void) | ||||
| static int load_module(void *mod) | ||||
| { | ||||
| 	int res; | ||||
| 	res=ast_register_translator(&ilbctolin); | ||||
| 	res = ast_register_translator(&ilbctolin, mod); | ||||
| 	if (!res)  | ||||
| 		res=ast_register_translator(&lintoilbc); | ||||
| 		res=ast_register_translator(&lintoilbc, mod); | ||||
| 	else | ||||
| 		ast_unregister_translator(&ilbctolin); | ||||
| 	return res; | ||||
| } | ||||
|  | ||||
| const char *description(void) | ||||
| static const char *description(void) | ||||
| { | ||||
| 	return tdesc; | ||||
| } | ||||
|  | ||||
| int usecount(void) | ||||
| { | ||||
| 	return me.usecnt; | ||||
| } | ||||
|  | ||||
| const char *key() | ||||
| static const char *key(void) | ||||
| { | ||||
| 	return ASTERISK_GPL_KEY; | ||||
| } | ||||
|  | ||||
| STD_MOD(MOD_1, NULL, NULL, NULL); | ||||
|   | ||||
		Reference in New Issue
	
	Block a user