kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-31 02:37:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_agi.c: Ensure SIGCHLD handler functions are properly balanced.

Browse Source 
Calls to `ast_replace_sigchld()` and `ast_unreplace_sigchld()` must be
balanced to ensure that we can capture the exit status of child
processes when we need to. This extends to functions that call
`ast_replace_sigchld()` and `ast_unreplace_sigchld()` such as
`ast_safe_fork()` and `ast_safe_fork_cleanup()`.

The primary change here is ensuring that we do not call
`ast_safe_fork_cleanup()` in `res_agi.c` if we have not previously
called `ast_safe_fork()`.

Additionally we reinforce some of the documentation and add an
assertion to, ideally, catch this sooner were this to happen again.

Fixes #922
This commit is contained in:
Sean Bright
2024-09-30 11:48:56 -04:00
committed by asterisk-org-access-app[bot]
parent d1bba7efc0
commit e76f671810
4 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
res/res_agi.c
View File

@@ -2192,12 +2192,15 @@ static enum agi_result launch_ha_netscript(char *agiurl, char *argv[], int *fds)
return AGI_RESULT_FAILURE;
}
static enum agi_result launch_script(struct ast_channel *chan, char *script, int argc, char *argv[], int *fds, int *efd, int *opid)
static enum agi_result launch_script(struct ast_channel *chan, char *script, int argc, char *argv[], int *fds, int *efd, int *opid, int *safe_fork_called)
{
char tmp[256];
int pid, toast[2], fromast[2], audio[2], res;
struct stat st;
/* We should not call ast_safe_fork_cleanup() if we never call ast_safe_fork(1) */
*safe_fork_called = 0;
if (!strncasecmp(script, "agi://", 6)) {
return (efd == NULL) ? launch_netscript(script, argv, fds) : AGI_RESULT_FAILURE;
}
@@ -2252,6 +2255,8 @@ static enum agi_result launch_script(struct ast_channel *chan, char *script, int
}
}
*safe_fork_called = 1;
if ((pid = ast_safe_fork(1)) < 0) {
ast_log(LOG_WARNING, "Failed to fork(): %s\n", strerror(errno));
return AGI_RESULT_FAILURE;
@@ -4531,6 +4536,7 @@ static int agi_exec_full(struct ast_channel *chan, const char *data, int enhance
enum agi_result res;
char *buf;
int fds[2], efd = -1, pid = -1;
int safe_fork_called = 0;
AST_DECLARE_APP_ARGS(args,
AST_APP_ARG(arg)[MAX_ARGS];
);
@@ -4553,7 +4559,7 @@ static int agi_exec_full(struct ast_channel *chan, const char *data, int enhance
return -1;
}
#endif
res = launch_script(chan, args.arg[0], args.argc, args.arg, fds, enhanced ? &efd : NULL, &pid);
res = launch_script(chan, args.arg[0], args.argc, args.arg, fds, enhanced ? &efd : NULL, &pid, &safe_fork_called);
/* Async AGI do not require run_agi(), so just proceed if normal AGI
or Fast AGI are setup with success. */
if (res == AGI_RESULT_SUCCESS || res == AGI_RESULT_SUCCESS_FAST) {
@@ -4571,7 +4577,9 @@ static int agi_exec_full(struct ast_channel *chan, const char *data, int enhance
if (efd > -1)
close(efd);
}
ast_safe_fork_cleanup();
if (safe_fork_called) {
ast_safe_fork_cleanup();
}
switch (res) {
case AGI_RESULT_SUCCESS: