From e83bfee678c358c14ffdd7e94924b1e987a939e9 Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Wed, 25 Jan 2006 19:14:43 +0000 Subject: [PATCH] don't call ast_update_realtime with uninitialized variables if we get a registration with an expirey of 0 seconds (issue #6173) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@8677 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- channels/chan_sip.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 701d695de5..80c2df5ce6 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -1590,16 +1590,15 @@ static void realtime_update_peer(const char *peername, struct sockaddr_in *sin, { char port[10]; char ipaddr[20]; - char regseconds[20] = "0"; + char regseconds[20]; + time_t nowtime; + + time(&nowtime); + nowtime += expirey; + snprintf(regseconds, sizeof(regseconds), "%d", (int)nowtime); /* Expiration time */ + ast_inet_ntoa(ipaddr, sizeof(ipaddr), sin->sin_addr); + snprintf(port, sizeof(port), "%d", ntohs(sin->sin_port)); - if (expirey) { /* Registration */ - time_t nowtime; - time(&nowtime); - nowtime += expirey; - snprintf(regseconds, sizeof(regseconds), "%d", (int)nowtime); /* Expiration time */ - ast_inet_ntoa(ipaddr, sizeof(ipaddr), sin->sin_addr); - snprintf(port, sizeof(port), "%d", ntohs(sin->sin_port)); - } if (fullcontact) ast_update_realtime("sippeers", "name", peername, "ipaddr", ipaddr, "port", port, "regseconds", regseconds, "username", username, "fullcontact", fullcontact, NULL); else