kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-12 15:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_ari_channels: Return a 404 response when a requested channel variable does not exist.

Browse Source 
This change makes it so that if a channel variable is requested and it does not exist
a 404 response will be returned instead of an allocation failed response. This makes
it easier to debug and figure out what is going on for a user.

ASTERISK-24677 #close
Reported by: Joshua Colp


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@432154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Joshua Colp
2015-02-21 20:47:19 +00:00
parent 7a507ae31a
commit f726304283
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
res/ari/resource_channels.c
View File

@@ -1242,6 +1242,11 @@ void ast_ari_channels_get_channel_var(struct ast_variable *headers,
ast_assert(response != NULL);
if (!value) {
ast_ari_response_alloc_failed(response);
return;
}
if (ast_strlen_zero(args->variable)) {
ast_ari_response_error(
response, 400, "Bad Request",
@@ -1280,7 +1285,9 @@ void ast_ari_channels_get_channel_var(struct ast_variable *headers,
}
} else {
if (!ast_str_retrieve_variable(&value, 0, channel, NULL, args->variable)) {
ast_ari_response_alloc_failed(response);
ast_ari_response_error(
response, 404, "Variable Not Found",
"Provided variable was not found");
return;
}
}