From fcd288a33eaba5a3c37fcc22da88c20cc2f4bbb8 Mon Sep 17 00:00:00 2001 From: Mark Michelson Date: Fri, 25 Apr 2008 19:32:02 +0000 Subject: [PATCH] Move the unlock of the spyee channel to outside the start_spying() function so that the channel is not unlocked twice when using whisper mode. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114662 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- apps/app_chanspy.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/apps/app_chanspy.c b/apps/app_chanspy.c index 159fdb954b..b58b6d1ef4 100644 --- a/apps/app_chanspy.c +++ b/apps/app_chanspy.c @@ -208,12 +208,9 @@ static int start_spying(struct ast_channel *chan, const char *spychan_name, stru res = ast_audiohook_attach(chan, audiohook); - if (!res && ast_test_flag(chan, AST_FLAG_NBRIDGE) && (peer = ast_bridged_channel(chan))) { - ast_channel_unlock(chan); + if (!res && ast_test_flag(chan, AST_FLAG_NBRIDGE) && (peer = ast_bridged_channel(chan))) { ast_softhangup(peer, AST_SOFTHANGUP_UNBRIDGE); - } else - ast_channel_unlock(chan); - + } return res; } @@ -263,16 +260,18 @@ static int channel_spy(struct ast_channel *chan, struct chanspy_ds *spyee_chansp ast_audiohook_init(&csth.spy_audiohook, AST_AUDIOHOOK_TYPE_SPY, "ChanSpy"); - if (start_spying(spyee, spyer_name, &csth.spy_audiohook)) { /* Unlocks spyee */ + if (start_spying(spyee, spyer_name, &csth.spy_audiohook)) { ast_audiohook_destroy(&csth.spy_audiohook); + ast_channel_unlock(spyee); return 0; } if (ast_test_flag(flags, OPTION_WHISPER)) { ast_audiohook_init(&csth.whisper_audiohook, AST_AUDIOHOOK_TYPE_WHISPER, "ChanSpy"); - start_spying(spyee, spyer_name, &csth.whisper_audiohook); /* Unlocks spyee */ + start_spying(spyee, spyer_name, &csth.whisper_audiohook); } + ast_channel_unlock(spyee); spyee = NULL; csth.volfactor = *volfactor;