Jason Parker
d80ecba23f
Remove a needless (and incorrect) call to feof() after fgets().
...
This would have exited the loop early if you had an authentication file with no newline at the end.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101822 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 17:41:40 +00:00
Russell Bryant
aa58033acb
off by one error
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 17:27:02 +00:00
Russell Bryant
552f2e1b4c
Don't overwrite the last character of a line if it's not a newline. This would
...
happen if the last line in the file doesn't have a newline.
(pointed out by Qwell)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 17:23:47 +00:00
Tilghman Lesher
df1dc7741d
Compatibility fix for OpenWRT (reported by Brian Capouch via the mailing list)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101772 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 15:55:58 +00:00
Russell Bryant
fe59cfa7aa
Add some more sanity checking on IAX2 dial strings for the case that no peer
...
or hostname was provided, which is the one part of the dial string that is
absolutely required. If it's not there, bail out.
(closes issue #11897 )
Reported by sokhapkin
Patch by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101693 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 00:32:49 +00:00
Mark Michelson
a4c24a807c
From bugtracker: "fix totalAnalysisTime to handle periods of no channel activity"
...
(closes issue #9256 )
Reported by: cmaj
Patches:
amd-dont-wait-too-long-for-frames-take3.diff.txt uploaded by cmaj (license 111)
Tested by: cmaj, skygreg, ZX81, rjain
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101649 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 00:06:37 +00:00
Russell Bryant
e4ee2274a1
Fix a couple of places where ast_frfree() was not called on a frame that came
...
from a translator. This showed itself by g729 decoders not getting released.
Since the flag inside the translator frame never got unset by freeing the frame
to indicate it was no longer in use, the translators never got destroyed, and
thus the g729 licenses were not released.
(closes issue #11892 )
Reported by: xrg
Patches:
11892.diff uploaded by russell (license 2)
Tested by: xrg, russell
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101601 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 23:10:06 +00:00
Mark Michelson
bd9a40f98a
1. Prevent the addition of an extra '/' to the beginning of an absolute pathname.
...
2. If ast_monitor_change_fname is called and the new filename is the same as the old, then exit early and don't set the
filename_changed field in the monitor structure. Setting it in this case was causing ast_monitor_stop to erroneously
delete them.
(closes issue #11741 )
Reported by: garlew
Tested by: putnopvut
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101531 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 21:00:24 +00:00
Jason Parker
9742fb53fe
Solaris compat fixes for struct in_addr funkiness.
...
Issue #11885 , patch by snuffy.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101482 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:52:49 +00:00
Steve Murphy
595ab7340d
closes issue #11845 ; that's the one where there's a 1004 byte cdr leak with every AMI Redirect to a zap channel
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101480 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:30:37 +00:00
Russell Bryant
0343bf8348
Add more missing locking of the agents list ...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:17:05 +00:00
Russell Bryant
70200cec77
Move the locking from find_agent() into the agent dialplan function handler to
...
ensure that the agent doesn't disappear while we're looking at it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:07:46 +00:00
Russell Bryant
c6c7c3bf58
Add missing locking to the find_agent() function.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101413 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:04:52 +00:00
Joshua Colp
7b31f51cf9
Fix an issue where if a frame of higher sample size preceeded a frame of lower sample size and ast_slinfactory_read was called with a sample size of the combined values or higher a crash would happen.
...
(closes issue #11878 )
Reported by: stuarth
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101222 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-30 15:41:04 +00:00
Jason Parker
ebbc70daab
Change default config to use descending channel order of groups, rather than ascending.
...
Fixes a potential source of confusion in glare-type situations.
Issue 11875, reported by JimVanM.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101219 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-30 15:34:37 +00:00
Mark Michelson
2e4650c242
Fix a logic error with regards to autofill. Prior to this change, it was possible
...
for a caller to go out of turn if autofill were enabled and callers ahead in the queue were attempting
to call a member. This change fixes this.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101216 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-30 15:23:00 +00:00
Olle Johansson
5e02b0d76e
Stop musiconhold on attended transfer.
...
(closes issue #11872 )
Reported by: gareth
Patches:
svn-101018.patch uploaded by gareth (license 208)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-30 11:20:31 +00:00
Dwayne M. Hubbard
68a44cc066
updated build_tools to handle the autotag directory structure changes; changes related to BE-353. Patch by Russell and reviewed by Me.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101080 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 23:50:42 +00:00
Mark Michelson
da3e5f571a
Remove a memory leak from updating realtime queues
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 23:02:03 +00:00
Mark Michelson
ad19e1c4b6
Fixing an erroneous return value returned when attempting to pause or unpause a queue member
...
fails.
Fixes BE-366, thanks to John Bigelow for writing the patch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100973 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 19:39:00 +00:00
Joshua Colp
f665fa0556
Don't forget to record the channel so we know whether it is bridged or not later.
...
(closes issue #11811 )
Reported by: slavon
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100934 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 17:57:05 +00:00
Russell Bryant
f8c69c7d92
Fix the last couple of issues related to building from a path that contains spaces.
...
(closes issue #11834 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100932 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 17:43:41 +00:00
Jason Parker
f60be6bdb8
Initialize an array to 0s if config option not specified.
...
(closes issue #11860 )
Patches:
misdn_get_config.v1.diff uploaded by IgorG (license 20)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100930 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 17:41:43 +00:00
Russell Bryant
2f4510988c
Use GNU make magic instead of shell magic to escape spaces in the working directory.
...
(related to issue #11834 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100922 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 17:21:33 +00:00
Russell Bryant
c8b0628cc7
Fix building Asterisk when the working path has spaces in it.
...
(closes issue #11834 )
Reported by: spendergrass
Patched by: me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100882 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 17:06:43 +00:00
Jason Parker
75007e2ab5
Allow zap groups above 30 to work properly.
...
(closes issue #11590 )
Reported by: tbsky
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100835 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 16:10:00 +00:00
Christian Richter
31c5fc22a5
fixed potential segfault in misdn show channels CLI command
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100793 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 10:36:19 +00:00
Olle Johansson
52cfa83d42
(closes issue #11736 )
...
Reported by: MVF
Patches:
bug11736-2.diff uploaded by oej (license 306)
Tested by: oej, MVF, revolution
(russellb: This was the showstopper for the release.)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100740 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 08:26:48 +00:00
Tilghman Lesher
44cdbc7d00
WaitExten didn't handle AbsoluteTimeout properly (went to 't' instead of 'T')
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100675 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 21:02:02 +00:00
Mark Michelson
d53c693509
Undoing the deprecation of chan_vpb. It is alive and well.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100673 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 20:55:56 +00:00
Jason Parker
cec60d345d
When using ODBC_STORAGE, make sure we put greeting files into the database like we do with the others.
...
Issue #11795
Reported by: dimas
Patches:
vmgreet.patch uploaded by dimas (license 88)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 20:42:43 +00:00
Russell Bryant
fe50ae6de5
For some reason, the use of this strdupa() is leading to memory corruption on
...
freebsd sparc64. This trivial workaround fixes it.
(closes issue #10300 , closes issue #11857 , reported by mattias04 and Home-of-the-Brave)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100629 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 18:34:20 +00:00
Russell Bryant
9b53acdbf5
Fix a crash in ast_masq_park_call()
...
(issue #11342 )
Reported by: DEA
Patches:
res_features-park.txt uploaded by DEA (license 3)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100626 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 18:26:31 +00:00
Jason Parker
58a4fa50ce
Correct a comment which made little/no sense.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100624 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 18:23:09 +00:00
Russell Bryant
ef78f25e8a
Make some deadlock related fixes. These bugs were discovered and reported
...
internally at Digium by Steve Pitts.
- Fix up chan_local to ensure that the channel lock is held before the local
pvt lock.
- Don't hold the channel lock when executing the timing function, as it can
cause a deadlock when using chan_local. This actually changes the code back
to be how it was before the change for issue #10765 . But, I added some other
locking that I think will prevent the problem reported there, as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 17:15:41 +00:00
Tilghman Lesher
7060a6888d
When deleting a task from the scheduler, ignoring the return value could
...
possibly cause memory to be accessed after it is freed, which causes all
sorts of random memory corruption. Instead, if a deletion fails, wait a
bit and try again (noting that another thread could change our taskid
value).
(closes issue #11386 )
Reported by: flujan
Patches:
20080124__bug11386.diff.txt uploaded by Corydon76 (license 14)
Tested by: Corydon76, flujan, stuarth`
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100465 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-27 21:59:53 +00:00
Mark Michelson
53859e0bfc
Deprecating chan_vpb. It is now preferred that users of Voicetronix products
...
use chan_zap in combination with their zaptel drivers.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100418 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-25 22:32:41 +00:00
Jason Parker
a70508ed3d
This would have never been true, since we're passing (sizeof(req.data) - 1) as the len to recvfrom().
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-25 21:24:49 +00:00
Kevin P. Fleming
cc750dc9ce
make these macros not assume that the only other field in the structure is 'argc'... this is true when someone uses AST_DECLARE_APP_ARGS, but it's perfectly reasonable to define your own structure as long as it has the right fields
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-24 21:57:41 +00:00
Russell Bryant
8f27d3ce7c
Update main Asterisk copyright info to 2008
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100164 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-24 17:22:09 +00:00
Jason Parker
9bc4c3e533
Fix compilation on Solaris.
...
(closes issue #11832 )
Patches:
bug-11832.diff uploaded by snuffy (license 35)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100138 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-24 16:41:29 +00:00
Olle Johansson
107c1c37b4
Second attempt. Don't change invitestate when receiving 18x messages in CANCEL state.
...
(issue #11736 )
Reported by: MVF
Patch by oej.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99978 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 21:07:16 +00:00
Olle Johansson
d95d9d7132
Make sure we don't cancel destruction on calls in CANCEL state, even if we
...
get 183 while waiting for answer on our CANCEL.
(issue #11736 )
Reported by: MVF
Patches:
bug11736.txt uploaded by oej (license 306)
Tested by: MVF
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99977 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 20:58:20 +00:00
Mark Michelson
1d9576115c
Fixing a typo.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99975 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 20:25:00 +00:00
Russell Bryant
ece4c9c40c
ChanSpy issues a beep when it starts at the beginning of a list of channels to
...
potentially spy on. However, if there were no matching channels, it would beep
at you over and over, which is pretty annoying. Now, it will only beep once in
the case that there are no channels to spy on, but it will still beep again once
it reaches the beginning of the channel list again.
(closes issue #11738 , patched by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 17:46:55 +00:00
Mark Michelson
3e54e684b2
These flag tests were illogical. They were testing sip_peer flags on a sip_pvt.
...
Thanks to Russell for helping to get this odd problem figured out.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99878 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 16:18:04 +00:00
Tilghman Lesher
60c9fba58f
When we reset the password via an external command, we should also reset the
...
password stored in the in-memory list, too (otherwise it doesn't really take
effect).
(closes issue #11809 )
Reported by: davetroy
Patches:
fix_externpass.diff uploaded by davetroy (license 384)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99777 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 04:31:51 +00:00
Tilghman Lesher
d97a51a50b
Oops, should have checked for a NULL obj, here, too
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99775 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 04:20:15 +00:00
Tilghman Lesher
d9f3861f72
Just confirmed that all current platforms need this header file
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99718 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 00:56:06 +00:00
Olle Johansson
f9cf98d4bf
Thanks to Russell's education I realize that BUFSIZ has changed since I learned the C language
...
over 20 years ago... Resetting chan_sip to the size of BUFSIZ that I expected in my old
head to avoid to heavy memory allocations on some systems.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99652 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-22 20:56:09 +00:00