Commit Graph

16747 Commits

Author SHA1 Message Date
Sean Bright
03e4997ceb If we encounter something in mailbox options that we don't grok, then
spit out a warning instead of just silently ignoring it.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 14:59:33 +00:00
Sean Bright
61664ec58b Make sure to compare the correct number of characters when special-casing
our DAHDI operator mode stuff.  Technically, it would work fine, as 'DAH'
is currently unique amongst our channel technologies, but as Jared points
out:

  <@jsmith> Sure... as long as the technology starts whith DAH.... but
            it could be DAHDOO!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 12:01:36 +00:00
Richard Mudgett
c2d9b9c009 Independent change from branch issue8824 that is not part of COLP. (-r142574 rmudgett)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 02:02:39 +00:00
Terry Wilson
cfaef11e0f A blind transfer to the parking thread would cause a segfault because copy_request accesses dst->data w/o being able to tell whether it is proerly initialized
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146970 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 00:02:19 +00:00
Tilghman Lesher
eaa1b73fcf Update documentation; AST_THREADSTORAGE() in trunk only takes a single
argument.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146928 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 23:21:02 +00:00
Michiel van Baak
4560279c69 All ODBC parts can now use either unixodbc or iodbc.
This allows for the ODBC parts to work on OpenBSD as well.

99.99% of the work is done by seanbright (bow, bow) and I actually
did nothing but test and yell at him that it still didn't work :)

Thanks for helping out !


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146925 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 23:14:33 +00:00
Jeff Peeler
2ec290b09d Similar to r143204, masquerade the channel in the case of Park being called from AGI.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 23:08:21 +00:00
Jeff Peeler
623bc9d82a Mvanbaak said this was needed to compile on OpenBSD, so put it in the OpenBSD section.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146920 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 22:59:58 +00:00
Jeff Peeler
50923eab5d This commit squashes together three commits because the wrong approach was originally used. (One of the commits was only one line.)
1) r143204:
The main change here was to masquerade the channel if the channel that was to be parked was running a PBX on it. The PBX thread can then maintain full control of the channel (the zombie) as it expects to while allowing the parking thread full control of the real (parked) channel.

2) r143270:
Changed park_call_full to hold the parkinglot lock a little longer, which protects the parkeduser struct from being freed out from underneath. Made sure that the parking extension is added to the parking context while holding the lock thereby ensuring that there are no spurious warnings from removal attempts when a hangup occurs while the parking lot is being announced.

3) r143475: (the one liner)
compare peer and chan instead of looking at the parked user (pu), which could have possibly already have been freed by the parking thread



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 22:26:25 +00:00
Jeff Peeler
abc88c1d61 fix some comment placement
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146877 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 22:08:40 +00:00
Jeff Peeler
7d8d1f50bb Explicitly set args in park_call_exec NULL so in the case of no options being passed in, there
is no garbage attempted to be used. Also, do not set args to unknown value again if there are
 no options passed in.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146875 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 22:03:01 +00:00
Michiel van Baak
cd4829706a make aescrypt.c compile on OpenBSD again
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146807 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 21:18:13 +00:00
Tilghman Lesher
63b165dbb9 Merged revisions 146799 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r146799 | tilghman | 2008-10-06 15:52:04 -0500 (Mon, 06 Oct 2008) | 8 lines
  
  Dialplan functions should not actually return 0, unless they have modified the
  workspace.  To signal an error (and no change to the workspace), -1 should be
  returned instead.
  (closes issue #13340)
   Reported by: kryptolus
   Patches: 
         20080827__bug13340__2.diff.txt uploaded by Corydon76 (license 14)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 21:09:05 +00:00
Sean Bright
9b0a2e5231 Pretty-print a couple configure options
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146738 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 17:32:02 +00:00
Tilghman Lesher
8a457d94e2 Merged revisions 146711 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r146711 | tilghman | 2008-10-06 11:51:21 -0500 (Mon, 06 Oct 2008) | 9 lines
  
  Check whether an extension exists in the _call method, rather than the _alloc
  method, because we need to evaluate the callerid (since that data affects
  whether an extension exists).
  (closes issue #13343)
   Reported by: efutch
   Patches: 
         20080915__bug13343.diff.txt uploaded by Corydon76 (license 14)
   Tested by: efutch
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146713 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 16:52:14 +00:00
Kevin P. Fleming
b6d086adbf Merged revisions 146643 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r146643 | kpfleming | 2008-10-06 10:57:49 -0500 (Mon, 06 Oct 2008) | 8 lines
  
  ensure that the private structure for pseudo channels is created without 'leaking' configuration data from other configured channels
  
  (closes issue #13555)
  Reported by: jeffg
  Patches:
        issue_13555.patch uploaded by kpfleming (license 421)
  Tested by: jeffg
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146644 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 16:03:37 +00:00
Mark Michelson
b8aed684f5 This commit introduces a change to how the "joinempty"
and "leavewhenempty" options are configured in queues.conf.

Instead of using vague terms like "yes," "no," "loose," and
"strict," we now accept a comma-separated list of values
to determine when to consider a member available.

Extended details can be found in the queues.conf.sample
file. Note also that the above four referenced values are
still accepted for backwards-compatibility, but are mapped
internally to the new method of representing the option.

AST-105



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146640 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 15:29:56 +00:00
Sean Bright
690f97870c Make NOISY_BUILD work for the calls to cp in utils/Makefile
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 00:36:37 +00:00
Sean Bright
f8f25ff595 Quote arguments to cp so we can handle spaces in our paths.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146555 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 00:21:49 +00:00
Russell Bryant
f6e73e8661 Make this build on my mac.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146514 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-05 22:11:30 +00:00
Jason Parker
b37300a4a5 Recorded merge of revisions 146448 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r146448 | qwell | 2008-10-05 16:17:44 -0500 (Sun, 05 Oct 2008) | 1 line
  
  Fix silly formatting.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146449 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-05 21:21:03 +00:00
Sean Bright
6ecbf7cc7c This is far from optimal, but I just found a FreeBSD system without
md5 installed on it.  So look around for all of the different binaries
that we could possibly use.  I'd wager this gets completely replaced
by someone else in less than 24 hours... :)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146407 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-05 01:59:14 +00:00
Sean Bright
6855b63d44 Fix a bug with the last item in CLI history getting duplicated when
read from the .asterisk_history file (and subsequently being duplicated
when written).  We weren't checking the result of fgets() which meant
that we read the same line twice before feof() actually returned non-
zero.

Also, stop writing out an extra blank line between each item in the
history file, fix a minor off-by-one error, and use symbolic constants
rather than a hardcoded integer.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146359 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-04 16:20:31 +00:00
Sean Bright
36a3fb92fd Add ability to remotely reboot snom phones. Also cleaned up and
reorganized sip_notify.conf.sample a bit as well.  Tested snom
reboot on snom 360 and verified snom-check-cfg worked as well.

(closes issue #13601)
Reported by: mjc
Tested by: seanbright


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-04 01:54:44 +00:00
Sean Bright
93baafa8aa Blocked revisions 146244 via svnmerge
........
r146244 | seanbright | 2008-10-03 18:51:22 -0400 (Fri, 03 Oct 2008) | 6 lines

Change some preprocessor macros to struct definitions so that we get
app_rpt to build with DAHDI.

(closes issue #13576)
Reported by: blitzrage

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-03 22:54:57 +00:00
Jeff Peeler
4b22fb221c remove superfluous reference counting operations in manage_parkinglot since ao2_interator_next increments the ref count automatically
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-03 22:40:59 +00:00
Sean Bright
b29fb615ae Resolve a subtle bug where we would never successfully be able to get
the first item in the CLI entry list.  This was preventing '!' from
showing up in either 'help' or in tab completion.

(closes issue #13578)
Reported by: mvanbaak


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-03 22:10:18 +00:00
Jeff Peeler
c2933ffb5e Blocked revisions 146129 via svnmerge
........
r146129 | jpeeler | 2008-10-03 15:44:22 -0500 (Fri, 03 Oct 2008) | 7 lines

(closes issue #13425)
Reported by: mdu113
Tested by: mdu113

Similar to r143204, masquerade the channel in the case of Park being called from AGI.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146130 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-03 20:49:17 +00:00
Tilghman Lesher
c5aefa8ff6 document meetme schedule changes (related to issue #11040)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146081 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-03 18:30:39 +00:00
Michiel van Baak
504df4c573 put a note in CHANGES about the cli_cleanup done during AstriDevCon
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-03 17:36:30 +00:00
Terry Wilson
84b0093bef The dialing API should inherit datastores as well as variables
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-03 17:35:37 +00:00
Russell Bryant
1375164ad8 The 'P' command for ExternalIVR was also added in 1.6.0
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145962 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-02 19:30:45 +00:00
Russell Bryant
2546f9b450 TCP support for ExternalIVR went in to 1.6.1, not 1.6.0
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145959 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-02 19:27:37 +00:00
Michiel van Baak
9f1c67dce6 fix the 'meetme list', 'meetme list concise', 'meetme list $confno' and 'meetme list $confno concise' CLI commands
(closes issue #13586)
Reported by: john8675309
Help and feedback from eliel, thanks!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145915 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-02 18:02:26 +00:00
Tilghman Lesher
cf06228a2f Permit the syntax and synopsis fields to be set (for func_odbc).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-02 17:16:54 +00:00
Michiel van Baak
4ea05efd8b make this compile under devmode again
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-02 16:42:30 +00:00
Tilghman Lesher
7d7161b979 Blocked revisions 145839 via svnmerge
........
  r145839 | tilghman | 2008-10-02 11:39:56 -0500 (Thu, 02 Oct 2008) | 4 lines
  
  Backport support for some of the keyword modifications used in 1.6 (while warning that
  some options aren't really supported) and add some warning messages.  Some credit to
  oej, who was complaining in #asterisk-dev.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145840 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-02 16:40:32 +00:00
Sean Bright
3e102d8cfc This is much cleaner, methinks.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145771 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-02 15:28:48 +00:00
Tilghman Lesher
1697c6e588 Merged revisions 145751 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r145751 | tilghman | 2008-10-02 10:13:21 -0500 (Thu, 02 Oct 2008) | 3 lines
  
  Some sanity checks that may have led to prior crashes, found by codefreeze-lap
  (murf) on IRC.  Also some cleanup of incorrectly-used constants.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145752 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-02 15:17:16 +00:00
Sean Bright
2640afa40f Try a test compile using the GMime library. Some distros install gmime-config
in the base package instead of the -devel package.  Now we print a notice and
disable GMime support instead of bombing during the main compilation.

(closes issue #13583)
Reported by: arkadia


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145692 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 23:48:16 +00:00
Tilghman Lesher
529874de7b Add schedule extensions to app_meetme. In addition, the reporter found a
problem within strptime(3), which we are correcting here with ast_strptime().
(closes issue #11040)
 Reported by: DEA
 Patches: 
       20080910__bug11040.diff.txt uploaded by Corydon76 (license 14)
 Tested by: DEA


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145649 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 23:02:25 +00:00
Mark Michelson
7eae109418 Okay, this should really do it now. While I did manage
to fix blind transfers with my last commit here, I also
caused an unwanted side-effect. That is, only the first
priority of the 'h' extension would be executed when
a blind transfer occurred instead of all priorities.

Essentially, my last commit corrected the return value
of ast_bridge_call. However, the implementation still
was not 100% correct. Now it is.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 22:23:50 +00:00
Mark Michelson
e6799e1c99 if (!(x) == 0) is the same as
if (x).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145579 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 21:33:11 +00:00
Mark Michelson
a23b8c9158 The logic surrounding the return value of ast_spawn_extension
within ast_bridge_call was reversed.

This problem was observed when a blind transfer placed from
the callee channel of a test call failed.

While the problem I am solving here is exactly the same
as what was reported in issue #13584, the difference is
that this fix I am applying is trunk-only. Issue #13584
was reported against the 1.4 branch, and my tests
of 1.4's blind transfers appear to work fine.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145553 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 21:06:26 +00:00
Leif Madsen
803b6799de Merged revisions 145479 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r145479 | lmadsen | 2008-10-01 13:18:30 -0400 (Wed, 01 Oct 2008) | 6 lines
  
  Update the realtime_pgsql.sql script to create the setinterfacevar column.
  
  (closes issue #13549)
  Reported by: fiddur
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 17:26:20 +00:00
Tilghman Lesher
38401621f5 Initializing buffer prevents a segfault when arguments are incomplete.
(closes issue #13471)
 Reported by: alecdavis
 Patches: 
       20080916__bug13471.diff.txt uploaded by Corydon76 (license 14)
 Tested by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 15:44:06 +00:00
Mark Michelson
ae0d0de987 Too many times have I mistyped the word
'install' as 'isntall'

Now this typo shall no longer be a problem since
'make isntall' just builds the 'install' target.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145381 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 14:44:12 +00:00
Russell Bryant
17f3fc40f2 tabs to spaces
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-01 12:29:18 +00:00
Jeff Peeler
81415abc21 (closes issue #13337)
Reported by: pj
Tested by: pj

Set transport to SIP_TRANSPORT_UDP mode if not specified which fixes calls to get_transport returning UNKNOWN.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-30 22:21:19 +00:00
Russell Bryant
f1dd1fe1c7 Add support for call pickup on Snom phones. Asterisk now includes a magic
call-id in the dialog-info event package used with extension state subscriptions
on Snom phones.  Then, when the phone sends an INVITE with Replaces for the
special callid, Asterisk will perform a pickup on the extension that was
subscribed to.

The original code on this issue was submitted by xylome.  However, contributions
have been made by (at least) mgernoth and pkempgen.  The final patch was written
by seanbright, and includes the necessary logic to allow this work in a
technology independent way.

(closes issue #5014)
Reported by: xylome
Patches:
      issue5014-trunk.diff uploaded by seanbright (license 71)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145226 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-30 21:32:53 +00:00