Mark Michelson
222302c0a2
Account for the fact that sometimes headers may be terminated with \r\n instead of just \n
...
(closes issue #11043 , reported by yehavi)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86694 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 14:48:46 +00:00
Joshua Colp
0e9071a2e3
Move log message to before the frame it references is freed.
...
(closes issue #11050 )
Reported by: slavon
Patches:
channel.c.86662.diff uploaded by casper (license 55)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 14:27:03 +00:00
Joshua Colp
796cc69527
Fix tab completion for dundi show peer.
...
(closes issue #11041 )
Reported by: jsmith
Patches:
asterisk-dundicomplete.diff.txt uploaded by jamesgolovich (license 176)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86661 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 14:05:26 +00:00
Joshua Colp
fb53e2a7f5
Fixes for building under OpenSolaris.
...
(closes issue #11047 )
Reported by: snuffy
Patches:
11047-fixes.diff uploaded by snuffy (license 35)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86630 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 13:33:23 +00:00
Christian Richter
e4df4c58ec
we send DISCONNECT instead of RELEASE/RELEASE_COMPLETE if the dialplan does not match after an overlap call. Also added out_cause=1
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 09:21:15 +00:00
Joshua Colp
e2dcbeda0c
When returning a DTMF digit from ast_control_streamfile cast it as a char so that 0 does not overlap with the success return code.
...
(closes issue #11023 )
Reported by: cfc
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86502 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 16:38:29 +00:00
Joshua Colp
a5b69b3583
Fix two issues with domains and transfers. If a port was given in the hostname it was treated as part of the hostname. If domains were configured but external domains were not enabled all transfers would be considered remote.
...
(closes issue #11027 )
Reported by: ramonpeek
Patches:
11027-1.diff uploaded by ramonpeek (license 266)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 15:33:49 +00:00
Joshua Colp
918ee9ae5b
Set port number in received as information for registrations as well.
...
(closes issue #11028 )
Reported by: brad-x
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 15:08:12 +00:00
TransNexus OSP Development
36ffd8e75b
Fixed OSP module did not report source/devinfo IP in correct format.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86438 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 01:45:53 +00:00
Jason Parker
1e9e35c081
Correct documentation. I removed the wrong line..
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86406 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 22:01:02 +00:00
Jason Parker
7c84082d13
Add documentation for options in asterisk.conf
...
Issue 11029, patch by eserra
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 21:58:44 +00:00
Russell Bryant
74450c6eff
Revert erroneous commit.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86372 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 21:16:47 +00:00
Russell Bryant
236872e7c4
Add support for setting the maximum trunk size for IAX2 trunking
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86371 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 21:14:15 +00:00
Russell Bryant
9df6ebe9b9
The channel needs to stay locked while running timer callbacks, as they access
...
and modify channel data that may change elsewhere. I went through every timer
callback in the source tree to make sure that none of them did any additional
locking that could introduce deadlocks, and all is well.
(closes issue #10765 )
Reported by: Ivan
Patches:
ast_1_4_11_svn_patch_channel_rc.diff uploaded by Ivan (license 229)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86330 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 18:03:10 +00:00
Mark Michelson
c9935ba132
If a non-existent file is specified to be played either as a periodic announcement
...
or as a hold/position announcement, the caller would be kicked out of the queue.
No longer does this happen.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86328 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 17:38:26 +00:00
Russell Bryant
f5fd6e1cb1
Execute the RELEASE operation on transcoder channels in the destroy callback.
...
(patch from jsloan)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 15:45:55 +00:00
Russell Bryant
9fcc010cce
Revert a change that I made for issue #10979 which, as has been pointed out to
...
me in issue #11018 , doesn't really make sense. There is no reason to have
the base64 decode function force a '\0' terminated buffer, when the result is
almost always binary, anyway. In fact, this caused some breakage, as some code
in res_crypto passed in a buffer exactly the right size to get its binary
result, which got stomped on by this patch.
(closes issue #11018 , reported by dimas)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86237 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-18 04:40:52 +00:00
Mark Michelson
cb55155ef1
Changing the strategy field of the call_queue struct to be signed instead of unsigned,
...
since the code attempts to set the strategy to -1 if you specify a bogus strategy.
While this isn't a huge issue in 1.4, it could be a problem for someone who, say, tries
to use the roundrobin strategy in trunk (despite all the deprecation warnings in 1.4).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86202 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 21:39:05 +00:00
Russell Bryant
ed426a7165
If Asterisk is in the middle of shutting down, respond to OPTIONS
...
with 503 Unavailable.
(closes issue #10994 )
Reported by: eserra
Patches:
sip-options-503.patch uploaded by eserra (license 45)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86149 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 17:57:45 +00:00
Joshua Colp
faf4b212eb
Whoops, forgot to remove the original sip_scheddestroy.
...
(closes issue #11010 )
Reported by: vadim
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86117 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 16:58:03 +00:00
Tilghman Lesher
d2c10c49fa
When runuser/rungroup is specified, a remote console could only be attained by root
...
(Closes issue #9999 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 15:23:51 +00:00
Joshua Colp
c9638888aa
Don't schedule dialog destruction if a MESSAGE is received using an existing dialog.
...
(closes issue #11010 )
Reported by: vadim
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86063 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 15:06:36 +00:00
Mark Michelson
098d0142fd
Since monitor-join is deprecated now, remove the example from the sample queues.conf file
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86032 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 23:35:31 +00:00
Mark Michelson
c3e4d3d02d
Updating UPGRADE.txt to reflect the deprecation of the monitor-join
...
queue option
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86031 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 23:16:08 +00:00
Mark Michelson
1ced2ef939
Adding deprecated warning to monitor-join option, since the plan is to
...
no longer support this in favor of monitor-type = mixmonitor
(related to issue #10885 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 22:49:10 +00:00
Russell Bryant
6f38c9d211
really picky formatting tweak ...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85997 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 22:36:16 +00:00
Russell Bryant
7cd8afd1ea
Some locking errors exposed the fact that the lock debugging code itself was
...
not thread safe. How ironic! Anyway, these changes ensure that the code that
is accessing the lock debugging data is thread-safe.
Many thanks to Ivan for finding and fixing the core issue here, and also
thanks to those that tested the patch and provided test results.
(closes issue #10571 )
(closes issue #10886 )
(closes issue #10875 )
(might close some others, as well ...)
Patches: (from issue #10571 )
ivan_ast_1_4_12_rel_patch_lock.h.diff uploaded by Ivan (license 229)
- a few small changes by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85994 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 22:14:36 +00:00
Mark Michelson
eb154e963c
Trying to remove a non-dynamic queue member via dynamic means can lead to some
...
interesting (read nasty) situations. This patch clears up the issue by making
only dynamic queue members removable via dynamic methods.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 21:14:34 +00:00
Tilghman Lesher
17ee21bf18
Also set up gmtoff (this is used in the %z gnu extension to strftime)
...
Reported and fixed by jcmoore
Closes issue #11002
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 19:41:40 +00:00
Russell Bryant
f192689840
Remove a pointless lock.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85896 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 19:10:01 +00:00
Mark Michelson
661aa4ba35
Fixing a double free which happens in the statechange thread.
...
(closes issue #10987 , reported by andrew)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 15:21:58 +00:00
Joshua Colp
ed25613860
Check to make sure a value has been given to the VMCOUNT dialplan function.
...
(closes issue #10996 )
Reported by: marsosa
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85850 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 14:52:22 +00:00
Joshua Colp
3a935a35a0
Fix memory allocation issue in threadstorage.
...
(closes issue #10995 )
Reported by: snuffy
Patches:
new-patch.diff uploaded by snuffy (license 35)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 14:19:39 +00:00
Philippe Sultan
ab36dd5843
Fix the output for this channel help CLI command
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 10:46:13 +00:00
Russell Bryant
d63883be92
Ensure that no pending state changes are leaked when the device state change
...
thread gets stopped on module unload.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85720 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 21:10:02 +00:00
Russell Bryant
87dc20fc03
Previously, app_queue created a thread to handle every single device state
...
change. I changed this a while ago in trunk for performance reasons. However,
bug 8407 points out that it is actually a race condition, causing device state
changes to get processed in random order. So, I backported my changes from
trunk to 1.4.
(closes issue #8407 , patch provided by tim_ringenbach, committed patch by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 20:59:27 +00:00
Tilghman Lesher
47b21bae6e
Don't execute a gosub if the arguments is zero-len (not just NULL)
...
Reported by davevg
Fixed by me
Closes issue #10985
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85687 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 20:29:35 +00:00
Russell Bryant
d47ebb492f
Add a small fix for the tw version of saying dates.
...
(closes issue #7827 )
Reported by: sharkey
Patches:
say.nits.patch uploaded by sharkey (license 172)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 20:21:27 +00:00
Jason Parker
eb9c632b90
Properly use DESTDIR in 'config' target.
...
Do not try to run chkconfig or similar if using DESTDIR.
Issue 10938, patch by cabal95.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85684 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 20:15:51 +00:00
Russell Bryant
02bb2bcbaa
Be pedantic about handling memory allocation failure.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85649 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 19:22:45 +00:00
Russell Bryant
9c47228dff
The loop in the handler for the "core show locks" could potentially block for
...
some amount of time. Be a little bit more careful and prepare all of the
output in an intermediary buffer while holding a global resource. Then, after
releasing it, send the output to ast_cli().
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 19:11:38 +00:00
Russell Bryant
3ba62c30b9
Make the default for the srvlookup option to be yes. It doesn't really make
...
sense for it to default to off. The default configuration file has it on, and
proper RFC behavior, as indicated by a comment in the code, is for it to be on.
So, let's have it on by default to make lives easier.
(closes issue #10954 , suggested by jtodd)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85604 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 16:54:57 +00:00
Joshua Colp
0912ca3c07
Document that DTMF based features only work when two channels are bridged together.
...
(closes issue #10773 )
Reported by: pbayley
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 16:39:59 +00:00
Russell Bryant
6b9addb181
Make a few changes so that characters in the upper half of the ISO-8859-1
...
character set don't get stripped when reading configuration.
(closes issue #10982 , dandre)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85561 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 16:34:13 +00:00
Joshua Colp
0f3e461074
Bring both DTMF begin and end frames up through to the core for DTMF feature handling.
...
(closes issue #10826 )
Reported by: dimas
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85559 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 16:22:02 +00:00
Russell Bryant
ca69081253
Ensure the buffer passed to ast_canmatch_extension() is properly initialized so
...
that it is null terminated.
(issue #10977 )
Reported by: dimas
Patches:
pbxdundi.patch uploaded by dimas (license 88)
- small mods by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85556 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 15:40:45 +00:00
Joshua Colp
3cc997694d
If Monitor or a spy was added to a P2P or native bridged channel bring the channel back to the generic bridging core so the monitor or spy operations work.
...
(closes issue #10943 )
Reported by: julianjm
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 14:55:04 +00:00
Russell Bryant
b5addcd9a5
Suppress a LOG_DEBUG message if debug is not enabled.
...
(closes issue #10980 )
Reported by: casper
Patches:
db.c.84633.diff uploaded by casper (license 55)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85548 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 13:16:23 +00:00
Russell Bryant
39f5611898
Make sure remote consoles unmute themselves again after reconnecting.
...
(closes issue #10847 )
Reported by: atis
Patches:
console_unmute_on_reconnect.patch uploaded by atis (license 242)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 13:05:45 +00:00
Russell Bryant
9b382ca76f
Make sure that the base64 decoder returns a terminated string.
...
(closes issue #10979 )
Reported by: ys
Patches:
util.c.diff uploaded by ys (license 281)
- small mods by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85543 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 12:48:10 +00:00