Commit Graph

1574 Commits

Author SHA1 Message Date
Steve Murphy
4f0d22fde1 For bug 7776, I have inserted a warning about Macro nesting vs. stack limitations
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44343 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-04 16:02:22 +00:00
Kevin P. Fleming
9c405de30d fix a logic error in my previous fix to the queue reload code
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 20:14:13 +00:00
Joshua Colp
87803a8ac6 Put in missing \ns on the end of ast_logs (issue #7936 reported by wojtekka)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43924 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 18:00:30 +00:00
Kevin P. Fleming
7620e04612 fix buggy (and overly complex) loop used during reload of app_queue for static member list updating
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 17:31:57 +00:00
BJ Weschke
fb599cc53e app_queue is comparing the device names incorrectly while checking their statuses. It's internal list of interfaces includes the dial string, while the argument passed to this function does not have the dial string (/n for a local channel). This causes it to ignore the device state changes because it thinks it belongs to none of its members. (#8040 reported and patch by tim_ringenbach)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:37:15 +00:00
Joshua Colp
34adb7efe6 Stop the stream after waitstream returns so that our formats get restored. (issue #7370 reported by kryptolus)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:13:55 +00:00
BJ Weschke
f6ddf4e7d4 Fix race condion crash with get_member_status (#7864 - tim_ringenbach reported and patched)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 15:18:05 +00:00
Tilghman Lesher
a2d98d6c7c Avoid inability to lock directory log message by creating the directory ahead of time. (Issue 7631)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43815 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 20:20:35 +00:00
Jason Parker
e247b8ab33 Playback() wasn't setting PLAYBACKSTATUS under several circumstances.
Playback() returns -1 on missing args - so should Background()


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 19:35:09 +00:00
Russell Bryant
a0da756f2a When parsing the sections of voicemail.conf that contain mailbox definitions,
don't introduce a length limit on the definition by using a 256 byte temporary
storage buffer.  Instead, make the temporary buffer just as big as it needs
to be to hold the entire mailbox definition.
(fixes BE-68)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43699 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:23:15 +00:00
Tilghman Lesher
83b377451c Two bugs when forwarding voicemail (Issue 7824):
1) delete=yes was ignored
2) maxmessages was ignored


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43634 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-25 21:14:41 +00:00
Joshua Colp
c6e25717b4 Yay another 'round of spy fixes! This fixes a small logic flaw with the cleanup function and a memory allocation issue. (issue #7960 reported by jojo & issue #7999 reported by aster1) Special thanks to csum77 for letting me into a box where this issue was happening.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-22 21:53:51 +00:00
Tilghman Lesher
e095711654 Whitespace change... really just an excuse to test repotools
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-21 17:01:48 +00:00
Matt O'Gorman
942768c022 fixes some verbose vs debug issues. patch from bug 2617
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43269 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 16:21:08 +00:00
Tilghman Lesher
6728ebb72c cid is passed to a destructive function; thus a copy is needed (issue 7961)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 12:28:55 +00:00
Joshua Colp
b1708137da Add deprecation notice about app_math (issue #7957 reported by k-egg)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43163 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 15:30:26 +00:00
Tilghman Lesher
88ccb83574 Directory used the wrong context for delivery of 0- and *- keypresses
(according to Directory's own documentation) - Issue 7965


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-17 13:54:34 +00:00
Tilghman Lesher
b2122691de When the marked user enters the conference, we should no longer timeout
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-16 04:44:02 +00:00
Tilghman Lesher
ca79503d56 Backport bugfix patch from 7918 to 1.2 - msg_cfg destroyed before used
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42892 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-13 19:51:24 +00:00
Tilghman Lesher
9c8d9ce377 When paging, only wait 5 seconds for the marked user to enter the conference.
After that, assume the paging already completed by the time the channel entered
the conference and drop back out.  (Issue 7275)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-11 21:47:23 +00:00
Tilghman Lesher
ec7535bba2 Jump logic was backwards: goto returns 0 if it succeeds, and we should jump if authentication fails. (Bug #7907)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-08 16:06:17 +00:00
Tilghman Lesher
0cfb462845 Format vulnerability fix - allowing the user to specify a format is not a good idea (Bug 7811)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42355 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 23:12:29 +00:00
Joshua Colp
68de3c0b29 Merge in last round of spy fixes. This should hopefully eliminate all the issues people have been seeing by distinctly separating what each component (core/spy) is responsible for. Core is responsible for adding a spy to a channel, feeding frames to the spy, removing the spy from a channel, and telling the spy to stop. Spy is responsible for reading frames in, and cleaning up after itself.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42054 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 20:02:48 +00:00
BJ Weschke
a05a361fc3 Make sure the forwarded channel inherits variables appropriately when we receive a call forward in the queue. (#7867 - raarts reported and patched)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41882 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:38:22 +00:00
BJ Weschke
aaf0ad7b77 Don't keep trying the same member in certain strategies when members of the queue are unavailable (#7278 - diLLec reported and patched) - This should have been patched here first and then merged into /trunk. My bad!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:13:38 +00:00
BJ Weschke
919cb0b1a8 Let's NOT spy on Zap/psuedo channels, mmmmmmmmk?
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41830 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:50:59 +00:00
BJ Weschke
c3b61adc5b Setting a retry of 0 is generally not a good idea and shouldn't be allowed. (#7574 - reported by regin)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41827 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:16:08 +00:00
Steve Murphy
6daea8e8fb According to a note added to 7731 by mneuhauser, this
will repair a break caused by the last fix (7731).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-28 19:06:55 +00:00
Tilghman Lesher
e83bbab1ec Text only - clarify the reason for entry into authentication mode when the skipuser option is ignored
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-25 15:07:16 +00:00
Tilghman Lesher
dad6bc4d32 Bug 7779 - Using initstate(3) means that we cannot unload this module once loaded.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-22 02:59:37 +00:00
Jason Parker
d98055d875 Fix a bug with app_voicemail when trying to use app_directory to leave messages
to another user (options 3, 5, 2).

If the context/extension didn't exist in the dialplan (and why should it have to?),
it would fail, saying that it's an "invalid extension".

Fix was different in svn trunk.

(issue BE-71)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40446 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-19 01:03:22 +00:00
Joshua Colp
afedbd97af Make app_macro compile again
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 16:18:08 +00:00
Steve Murphy
4098ad798d In app_macro, changed the previously changed upper recursion depth limit to a variable, default of the original val of 7. MACRO_RECURSION is a channel variable that will override the limit, but until I can understand and fix why this limit is neccessary, I am not advertising this variable in the docs. This fix mirrors the changes made in r40200 in trunk.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40220 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 16:07:21 +00:00
Steve Murphy
f4e47e9b51 This revision fixes bug 7731, the inability for macros to be called more than one level deep in the 'h' extension.
It also pushes up the limit of recursion depth from 7 to 20.




git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@39931 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-15 22:13:47 +00:00
Russell Bryant
e81646d2dd remove duplicate queue log entry when the caller exits on a timeout
(issue #7616, ppyy)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38972 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 08:08:48 +00:00
Russell Bryant
183541b44d make sure the priv-callerintros directory exists before trying to create a file
there (issue #7659, patch by hads, with some modifications by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38928 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 06:37:59 +00:00
Tilghman Lesher
84ad1fe0f3 Bug 7648 - Checking wrong count for plurality on new messages for Dutch language
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38761 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-03 05:22:19 +00:00
Kevin P. Fleming
7b9abdf138 use the enum that defines the option arguments, so that the likelihood of mismatched option indexes is reduced (which in this case was a bug, the volume argument was not checked properly)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-27 22:23:38 +00:00
Tilghman Lesher
ce37a590e5 Bug 7526 - previous commit broke app_sms
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37612 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-14 13:31:11 +00:00
Kevin P. Fleming
6ea65400a0 don't fail/abort if the message category sound file cannot be played, just generate a warning message and continue message playback
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-13 21:22:11 +00:00
Kevin P. Fleming
ff3890a952 fix a weird case where a lock file could be left (but would happen almost never)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37442 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 15:53:53 +00:00
Kevin P. Fleming
648bc1828d remove some more bad examples of using printf
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37419 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 13:54:10 +00:00
Tilghman Lesher
4bee2f3210 Bug 7349 - Directory did not work correctly when USE_ODBC_STORAGE was defined.
Note: Russell agreed that this should have worked, which is why this is
classified as a bugfix.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@36377 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-30 14:05:53 +00:00
BJ Weschke
64def5d791 We should lock the queue before we go making changes to member interface statuses.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@35669 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-23 11:30:17 +00:00
Joshua Colp
43ad959914 Call reset_user_pw upon changing the password using externpass (issue #7395 reported by Ryan Cumming)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34911 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 20:27:44 +00:00
Tilghman Lesher
4c688bb3b3 Issue 7357 - txt file left behind when going to operator. Also, fix a possible file descriptor leak.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34875 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 18:07:26 +00:00
Kevin P. Fleming
d00c50cd14 don't use prefixed structure names for internal structures
don't use a plural structure name for a singular object


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-15 13:30:22 +00:00
Tilghman Lesher
2159afd1ae VoicemailMain exits on any key, when the language is set to Italian, instead of
properly handling the key (issue 7353).


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-15 12:40:10 +00:00
Kevin P. Fleming
55ba8ef5c4 coding style cleanups on queue interface handling code that was committed for the last release
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34160 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 22:22:21 +00:00
Kevin P. Fleming
724b3d0004 clarify file headers that mention disclaimer usage
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34087 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 14:07:53 +00:00